Commit 1325a658347 for nodejs
commit 1325a65834777272f934504baab504130697b5d8
Author: Chengzhong Wu <legendecas@gmail.com>
Date: Wed Nov 18 09:47:05 2026 -0500
build: fix v8_internal_headers sources scraping
V8 now starts the `v8_internal_headers` source list with `sources = []`.
The GN scraper skips the empty list and matches
`v8_compiler_sources = [` instead, so every dependent of
`v8_internal_headers` compiled all of the compiler sources again. That
breaks the shared library link with duplicate symbols. Match the
`sources += [` list that holds the headers.
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/67070
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index 474bab8077a..2d5d07f9cb0 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -648,7 +648,7 @@
],
'direct_dependent_settings': {
'sources': [
- '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_header_set.\\"v8_internal_headers\\".*?sources = ")',
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_header_set.\\"v8_internal_headers\\".*?sources \\+= ")',
],
'conditions': [
['v8_enable_snapshot_compression==1', {