Commit 13475276bc4 for nodejs
commit 13475276bc4fc589718c593bbb089284f3b42ea3
Author: Hilary Asogwa <76795262+Dansatch@users.noreply.github.com>
Date: Sun Nov 15 22:01:09 2026 +0000
url: validate href setter receiver first
Validate the URL receiver before converting the assigned href value.
Fixes: https://github.com/nodejs/node/issues/67344
Signed-off-by: dansatch <dansatch98@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/67350
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
diff --git a/lib/internal/url.js b/lib/internal/url.js
index 0fe819fe129..2d1339702b9 100644
--- a/lib/internal/url.js
+++ b/lib/internal/url.js
@@ -1022,8 +1022,9 @@ class URL {
}
set href(value) {
+ const context = this.#context;
value = `${value}`;
- const href = bindingUrl.update(this.#context.href, updateActions.kHref, value);
+ const href = bindingUrl.update(context.href, updateActions.kHref, value);
if (!href) { throw new ERR_INVALID_URL(value); }
this.#updateContext(href, true);
}
diff --git a/test/parallel/test-whatwg-url-custom-href-side-effect.js b/test/parallel/test-whatwg-url-custom-href-side-effect.js
index 30967d9feae..daecb2a2226 100644
--- a/test/parallel/test-whatwg-url-custom-href-side-effect.js
+++ b/test/parallel/test-whatwg-url-custom-href-side-effect.js
@@ -13,3 +13,19 @@ assert.throws(() => {
});
assert.deepStrictEqual(url, ref);
+
+const setHref = Object.getOwnPropertyDescriptor(URL.prototype, 'href').set;
+let calls = 0;
+
+assert.throws(() => {
+ setHref.call({}, {
+ toString() {
+ calls++;
+ return 'https://example.com/';
+ },
+ });
+}, {
+ name: 'TypeError',
+});
+
+assert.strictEqual(calls, 0);