Commit 22d1b28d72 for openssl.org
commit 22d1b28d72e1638a214e1499c8c083cd4de317a4
Author: Richard Levitte <levitte@openssl.foundation>
Date: Thu Nov 5 10:15:50 2026 +0100
.github/workflows/ci.yml: pedantic buildtest-c++
--strict-warnings carries -pedantic -Werror, but those flags only land
in CFLAGS; the buildtest_cc_* programs, which check-c99 is the only
job to enable, are compiled with plain g++ defaults. g++ accepts
nonstandard constructs such as compound literals in C++ as a silent
extension, so C++ constructs that strict consumers (-pedantic-errors)
would reject slip through the one job meant to prove our public
headers C++-clean.
References: https://github.com/openssl/openssl/pull/33520#issuecomment-6654673077
Assisted-by: Pi:moonshotai/kimi-k3
Signed-off-by: Richard Levitte <levitte@openssl.foundation>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Merge-date: Tue Nov 10 15:32:22 2026
Merged-from: https://github.com/openssl/openssl/pull/33553
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9670354fd5..d669d9c1e5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -73,7 +73,7 @@ jobs:
with:
persist-credentials: false
- name: config
- run: CPPFLAGS='-std=c99 -D_XOPEN_SOURCE=1 -D_POSIX_C_SOURCE=200809L' ./config --strict-warnings --banner=Configured enable-sslkeylog no-asm no-secure-memory no-makedepend enable-buildtest-c++ enable-fips enable-lms && perl configdata.pm --dump
+ run: CPPFLAGS='-std=c99 -D_XOPEN_SOURCE=1 -D_POSIX_C_SOURCE=200809L' CXXFLAGS='-Werror=pedantic' ./config --strict-warnings --banner=Configured enable-sslkeylog no-asm no-secure-memory no-makedepend enable-buildtest-c++ enable-fips enable-lms && perl configdata.pm --dump
- name: make
run: make -s -j4