Commit 23a07321 for whisper.cpp
commit 23a0732193903a35f3ce877ec8ad4d04eaff47e0
Author: CC <65151926+realMoana@users.noreply.github.com>
Date: Wed Nov 11 15:02:06 2026 -0500
metal : prevent out-of-bounds reads in SOLVE_TRI kernel (llama/32103)
diff --git a/ggml/src/ggml-metal/kernels/solve_tri.metal b/ggml/src/ggml-metal/kernels/solve_tri.metal
index 50f16fac..216f605f 100644
--- a/ggml/src/ggml-metal/kernels/solve_tri.metal
+++ b/ggml/src/ggml-metal/kernels/solve_tri.metal
@@ -39,7 +39,9 @@ kernel void kernel_solve_tri_f32(
for (short t = 0; t*NW < N; ++t) {
const short idx = t*NW + tiisg;
- sh0_cur[idx] = src0_ptr[idx];
+ if (rr + sgitg < N && idx < N) {
+ sh0_cur[idx] = src0_ptr[idx];
+ }
}
src0_ptr += NSG*N;
@@ -60,7 +62,9 @@ kernel void kernel_solve_tri_f32(
for (short t = 0; t*NW < r; ++t) {
const short idx = t*NW + tiisg;
- sum += sh0_cur[idx] * dst_ptr[idx*K] * (idx < r);
+ if (idx < r) {
+ sum += sh0_cur[idx] * dst_ptr[idx*K];
+ }
}
sum = simd_sum(sum);