Commit 28553729d06 for nodejs
commit 28553729d0664a4e4f2a9de0161e771013dda371
Author: Joyee Cheung <joyeec9h3@gmail.com>
Date: Thu Oct 1 15:56:15 2026 +0200
deps: remove broken NamedPropertyDefinerCallbackV2 converter
This removal will be rolled in in a future V8 update too.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
diff --git a/common.gypi b/common.gypi
index db9b665b6ca..24ac3996976 100644
--- a/common.gypi
+++ b/common.gypi
@@ -44,7 +44,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
- 'v8_embedder_string': '-node.20',
+ 'v8_embedder_string': '-node.21',
##### V8 defaults for Node.js #####
diff --git a/deps/v8/include/v8-template.h b/deps/v8/include/v8-template.h
index 236b407a7fc..8c51703b8f3 100644
--- a/deps/v8/include/v8-template.h
+++ b/deps/v8/include/v8-template.h
@@ -769,11 +769,6 @@ struct NamedPropertyHandlerConfiguration {
NamedPropertySetterCallbackV2 value) {
return value;
}
- V8_DEPRECATED("Use NamedPropertySetterCallbackV2 setter instead")
- static NamedPropertySetterCallbackV2 ConvertSetter(
- NamedPropertySetterCallback value) {
- return NamedPropertySetterCallbackV2(value);
- }
static NamedPropertyDefinerCallbackV2 ConvertDefiner(std::nullptr_t) {
return nullptr;
@@ -782,11 +777,6 @@ struct NamedPropertyHandlerConfiguration {
NamedPropertyDefinerCallbackV2 value) {
return value;
}
- V8_DEPRECATED("Use NamedPropertyDefinerCallbackV2 definer instead")
- static NamedPropertyDefinerCallbackV2 ConvertDefiner(
- NamedPropertyDefinerCallback value) {
- return NamedPropertyDefinerCallbackV2(value);
- }
public:
// TODO(https://crbug.com/348660658): cleanup once migration to
@@ -900,11 +890,6 @@ struct IndexedPropertyHandlerConfiguration {
IndexedPropertySetterCallback value) {
return value;
}
- V8_DEPRECATED("Use IndexedPropertySetterCallback setter instead")
- static IndexedPropertySetterCallback ConvertSetter(
- IndexedPropertySetterCallbackV2 value) {
- return IndexedPropertySetterCallback(value);
- }
static IndexedPropertyDefinerCallback ConvertDefiner(std::nullptr_t) {
return nullptr;
@@ -913,11 +898,6 @@ struct IndexedPropertyHandlerConfiguration {
IndexedPropertyDefinerCallback value) {
return value;
}
- V8_DEPRECATED("Use IndexedPropertyDefinerCallback definer instead")
- static IndexedPropertyDefinerCallback ConvertDefiner(
- IndexedPropertyDefinerCallbackV2 value) {
- return IndexedPropertyDefinerCallback(value);
- }
public:
// TODO(https://crbug.com/348660658): cleanup once migration to