Commit 3bb7a915583 for woocommerce
commit 3bb7a91558317b72a361c75a73cdbe2fc84943fe
Author: Vlad Olaru <vlad.olaru@automattic.com>
Date: Fri Oct 9 08:51:32 2026 +0300
[tests] Remove the Save button workaround from the PayPal Standard E2E spec (#69612)
test(e2e): Remove the PayPal Standard Save button workaround
The PayPal Standard onboarding spec stripped the `disabled` attribute
from the settings Save button before clicking it, because in March the
button seemed never to enable during e2e runs (#63498). The workaround
also meant the spec no longer checked that editing a field enables
Save.
The button does enable under Playwright today. In the E2E environment,
`fill()` on the PayPal title field fires the `input` handler that
`settings.js` binds, both with and without the spec's Jetpack and HTTP
mocks, and the real spec passes without the workaround across repeated
runs, including under 6x CPU throttling. The one March CI failure
without the workaround left no logs, so its cause can't be confirmed.
Drop the helper and its two calls so the spec waits on the real
enabled state again. If CI shows a failure, its Playwright trace will
now say why.
Refs WOOPLUG-6372
diff --git a/plugins/woocommerce/changelog/fix-WOOPLUG-6372-remove-save-button-workaround b/plugins/woocommerce/changelog/fix-WOOPLUG-6372-remove-save-button-workaround
new file mode 100644
index 00000000000..8cc246c39df
--- /dev/null
+++ b/plugins/woocommerce/changelog/fix-WOOPLUG-6372-remove-save-button-workaround
@@ -0,0 +1,3 @@
+Significance: patch
+Type: dev
+Comment: Remove the Save button workaround from the PayPal Standard E2E spec; test-only change.
diff --git a/plugins/woocommerce/tests/e2e/tests/paypal/paypal.spec.ts b/plugins/woocommerce/tests/e2e/tests/paypal/paypal.spec.ts
index 4a403e3dae8..e8d58f9b1f5 100644
--- a/plugins/woocommerce/tests/e2e/tests/paypal/paypal.spec.ts
+++ b/plugins/woocommerce/tests/e2e/tests/paypal/paypal.spec.ts
@@ -79,24 +79,6 @@ test.describe(
return paypalDiv;
}
- /**
- * Temporary function to remove the disabled attribute from the Save changes button, as it is currently disabled by default and prevents saving changes in tests.
- * This should be removed once the underlying issue is resolved and the Save changes button can be enabled as expected.
- * See: https://github.com/woocommerce/woocommerce/issues/63498
- *
- * @param {Page} page The Playwright Page object representing the browser page to interact with.
- */
- async function enableSaveButton( page: Page ) {
- await page.evaluate( () => {
- const saveButton = document.querySelector(
- 'button[name="save"]'
- );
- if ( saveButton ) {
- saveButton.removeAttribute( 'disabled' );
- }
- } );
- }
-
test( 'PayPal Standard can be enabled', async ( { page } ) => {
await openPayments( page );
@@ -178,9 +160,6 @@ test.describe(
.locator( '#woocommerce_paypal_title' )
.fill( 'PayPal Custom Title ' + Date.now() );
- // TODO: Temporarily removing the disabled attribute from the Save changes button.
- await enableSaveButton( page );
-
await page
.getByRole( 'button', {
name: 'Save changes',
@@ -212,9 +191,6 @@ test.describe(
.locator( '#woocommerce_paypal_title' )
.fill( originalPayPalTitle );
- // TODO: Temporarily removing the disabled attribute from the Save changes button.
- await enableSaveButton( page );
-
await page
.getByRole( 'button', {
name: 'Save changes',