Commit 3cd33c48686 for nodejs
commit 3cd33c4868670c96169140caa59dc88a6afd6fbf
Author: Node.js GitHub Bot <github-bot@iojs.org>
Date: Tue Oct 13 05:04:10 2026 -0400
deps: update googletest to 988ea2c1798de7779f656df2281dd36d6039a17a
PR-URL: https://github.com/nodejs/node/pull/66652
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/deps/googletest/include/gtest/internal/gtest-param-util.h b/deps/googletest/include/gtest/internal/gtest-param-util.h
index 716779346a0..6e8a187c9d6 100644
--- a/deps/googletest/include/gtest/internal/gtest-param-util.h
+++ b/deps/googletest/include/gtest/internal/gtest-param-util.h
@@ -601,7 +601,7 @@ class [[nodiscard]] ParameterizedTestSuiteInfo
MakeAndRegisterTestInfo(
test_suite_name, test_name.c_str(),
- nullptr, // No type parameter.
+ /*type_param=*/nullptr, // No type parameter.
PrintToString(param).c_str(), test_info->code_location,
GetTestSuiteTypeId(),
SuiteApiResolver<TestSuite>::GetSetUpCaseOrSuite(file, line),
diff --git a/deps/googletest/src/gtest-filepath.cc b/deps/googletest/src/gtest-filepath.cc
index 902d8c7f64b..73a352fff0a 100644
--- a/deps/googletest/src/gtest-filepath.cc
+++ b/deps/googletest/src/gtest-filepath.cc
@@ -325,7 +325,7 @@ FilePath FilePath::GenerateUniqueFileName(const FilePath& directory,
// This does NOT check that a directory (or file) actually exists.
bool FilePath::IsDirectory() const {
return !pathname_.empty() &&
- IsPathSeparator(pathname_.c_str()[pathname_.length() - 1]);
+ IsPathSeparator(pathname_[pathname_.length() - 1]);
}
// Create directories so that path exists. Returns true if successful or if
diff --git a/deps/googletest/src/gtest-port.cc b/deps/googletest/src/gtest-port.cc
index 68f77f71247..e37a8bb1746 100644
--- a/deps/googletest/src/gtest-port.cc
+++ b/deps/googletest/src/gtest-port.cc
@@ -1143,7 +1143,7 @@ static std::string FlagToEnvVar(const char* flag) {
Message env_var;
for (size_t i = 0; i != full_flag.length(); i++) {
- env_var << ToUpper(full_flag.c_str()[i]);
+ env_var << ToUpper(full_flag[i]);
}
return env_var.GetString();