Commit 4254b3581c for bind
commit 4254b3581c1ed3a66a1040404c4c7c420c7c4472
Author: Matthijs Mekking <matthijs@isc.org>
Date: Mon Sep 21 17:40:10 2026 +0200
A positive "error reading" test case
Add a test case to ensure we actually emit the "error reading" message
when the private key files are missing.
diff --git a/bin/tests/system/kasp/tests_kasp.py b/bin/tests/system/kasp/tests_kasp.py
index a030228d22..fe4c03d6d1 100644
--- a/bin/tests/system/kasp/tests_kasp.py
+++ b/bin/tests/system/kasp/tests_kasp.py
@@ -352,6 +352,31 @@ def cb_remove_keyfiles(params, ksks=None, zsks=None):
isctest.kasp.check_dnssec_verify(servers["ns3"], zone)
+def cb_log_error_reading(roles, params, ksks=None, zsks=None):
+ servers = params["servers"]
+
+ isctest.log.info("check that it is logged if key files cannot be read")
+
+ messages = []
+
+ if "ksk" in roles:
+ for k in ksks:
+ messages.append(
+ f"dns_zone_findkeys: error reading {k.name}.private: file not found"
+ )
+
+ if "zsk" in roles:
+ for k in zsks:
+ messages.append(
+ f"dns_zone_findkeys: error reading {k.name}.private: file not found"
+ )
+
+ isctest.log.info(f"check messages: {messages}")
+
+ with servers["ns3"].watch_log_from_start() as watcher:
+ watcher.wait_for_sequence(messages)
+
+
@pytest.mark.parametrize(
"params",
[
@@ -459,6 +484,12 @@ def cb_remove_keyfiles(params, ksks=None, zsks=None):
f"ksk 63072000 {Algorithm.default().number} {Algorithm.default().bits} goal:omnipresent dnskey:omnipresent krrsig:omnipresent ds:omnipresent sep missing",
f"zsk 31536000 {Algorithm.default().number} {Algorithm.default().bits} goal:omnipresent dnskey:omnipresent zrrsig:omnipresent",
],
+ "additional-tests": [
+ {
+ "callback": cb_log_error_reading,
+ "arguments": ["ksk"],
+ },
+ ],
},
id="ksk-missing.autosign",
),
@@ -472,6 +503,12 @@ def cb_remove_keyfiles(params, ksks=None, zsks=None):
f"ksk 63072000 {Algorithm.default().number} {Algorithm.default().bits} goal:omnipresent dnskey:omnipresent krrsig:omnipresent ds:omnipresent sep",
f"zsk 31536000 {Algorithm.default().number} {Algorithm.default().bits} goal:omnipresent dnskey:omnipresent zrrsig:omnipresent missing",
],
+ "additional-tests": [
+ {
+ "callback": cb_log_error_reading,
+ "arguments": ["zsk"],
+ },
+ ],
},
id="zsk-missing.autosign",
),