Commit 57e6b3cf404 for nodejs
commit 57e6b3cf4046f8b83bf33ae0273bf0f079032104
Author: Joyee Cheung <joyeec9h3@gmail.com>
Date: Thu Oct 29 12:58:56 2026 +0100
deps: V8: cherry-pick c38986131c02
Original commit message:
Add V8_DISABLE_PRESERVE_MOST for embedders to opt out of preserve_most
preserve_most changes the calling convention, which clang
encodes in the mangled name (e.g. "U" instead of "A" for cdecl in the
Microsoft C++ ABI). A consumer whose toolchain does not support
the attribute would reference a differently mangled symbol.
This patch adds a V8_DISABLE_PRESERVE_MOST to disable it, so that
it's possible to link to V8 using different toolchains, as long
as the value of it is set consistently.
Refs: https://github.com/nodejs/node/pull/55784
Change-Id: I67b49e739942d4026ac060be35bb39ec22256cbd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8532546
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#111381}
Refs: https://github.com/v8/v8/commit/c38986131c02b6f24eb31d99d76ebf312a2b99aa
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/67070
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/common.gypi b/common.gypi
index 7c9305aa2d9..0f156f57672 100644
--- a/common.gypi
+++ b/common.gypi
@@ -50,7 +50,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
- 'v8_embedder_string': '-node.1',
+ 'v8_embedder_string': '-node.2',
##### V8 defaults for Node.js #####
diff --git a/deps/v8/include/v8config.h b/deps/v8/include/v8config.h
index b7aeeade6b8..3063b20885c 100644
--- a/deps/v8/include/v8config.h
+++ b/deps/v8/include/v8config.h
@@ -402,6 +402,7 @@ path. Add it with -I<path> to the command line
|| ((defined(__AARCH64EL__) || defined(_M_ARM64)) /* arm64, but ... */ \
&& !defined(_WIN32))) /* not on windows */ \
&& !defined(COMPONENT_BUILD) /* no component build */\
+ && !defined(V8_DISABLE_PRESERVE_MOST) /* embedder opt-out */ \
&& __clang_major__ >= 17 /* clang >= 17 */
# define V8_HAS_ATTRIBUTE_PRESERVE_MOST (__has_attribute(preserve_most))
#endif