Commit 67e45e4a87b for nodejs
commit 67e45e4a87be18af4a24b7a609138848e6f57840
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Thu Nov 12 16:39:25 2026 +0100
tools: enable strict mode for yamllint
Treats warnings as errors, so we can detect regressions.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/67380
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
diff --git a/.github/workflows/nix-changes.yml b/.github/workflows/nix-changes.yml
index 713e740e270..77964468915 100644
--- a/.github/workflows/nix-changes.yml
+++ b/.github/workflows/nix-changes.yml
@@ -50,7 +50,7 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 2
- persist-credentials: true # We need read access in case we need to fetch in `Compute requisites before change` step
+ persist-credentials: true # We need read access in case we need to fetch in `Compute requisites before change` step
sparse-checkout: |
shell.nix
tools/nix/
diff --git a/Makefile b/Makefile
index fbf6f3f5323..fa6979120dc 100644
--- a/Makefile
+++ b/Makefile
@@ -1715,15 +1715,17 @@ endif
# python -m pip install yamllint
# Try with '--system' if it fails without; the system may have set '--user'
lint-yaml-build: ## Build resources needed to lint YAML files.
+ifeq ($(YAMLLINT), tools/pip/site-packages/bin/yamllint)
$(info Pip installing yamllint on $(shell $(PYTHON) --version)...)
$(PYTHON) -m pip install --upgrade -t tools/pip/site-packages yamllint || \
$(PYTHON) -m pip install --upgrade --system -t tools/pip/site-packages yamllint
+endif
.PHONY: lint-yaml
ifneq ("","$(wildcard $(YAMLLINT))")
lint-yaml: ## Lint the YAML files with yamllint.
$(info Running YAML linter...)
- PYTHONPATH=tools/pip $(YAMLLINT) .
+ PYTHONPATH=tools/pip $(YAMLLINT) --strict .
else
lint-yaml:
$(warning YAML linting with yamllint is not available)
diff --git a/test/fixtures/test426/.github/workflows/ci.yml b/test/fixtures/test426/.github/workflows/ci.yml
index 72d33dddb54..0eb2f29f857 100644
--- a/test/fixtures/test426/.github/workflows/ci.yml
+++ b/test/fixtures/test426/.github/workflows/ci.yml
@@ -45,7 +45,7 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: read
- id-token: write # for npm trusted publishing
+ id-token: write # for npm trusted publishing
concurrency:
group: npm-publish
cancel-in-progress: false