Commit 6f3fd19b9a for ffmpeg
commit 6f3fd19b9a2525b399e3f5e34067d1950b226895
Author: Baptiste Coudurier <baptiste.coudurier@gmail.com>
Date: Wed Nov 11 12:05:58 2026 -0800
tests/checkasm/scene_sad: benchmark the width that is tested
check_scene_sad() halves the width for depths above 8, so that a row
of 16-bit samples fits in the stride, and randomizes and checks
width * HEIGHT samples. The benchmark call passed WIDTH instead, which
for these depths is twice the row size in bytes: each row ran into the
next one, and the last rows read past the randomized data into the
uninitialized second half of the buffers. The benchmark thus measured
a different workload than the one checked.
Pass width, as the call_ref() and call_new() calls do.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
diff --git a/tests/checkasm/scene_sad.c b/tests/checkasm/scene_sad.c
index bc33c428c6..b15df3087c 100644
--- a/tests/checkasm/scene_sad.c
+++ b/tests/checkasm/scene_sad.c
@@ -59,7 +59,7 @@ static void check_scene_sad(int depth)
depth, (unsigned long long) sum1, (unsigned long long) sum2);
fail();
}
- bench_new(src1, STRIDE, src2, STRIDE, WIDTH, HEIGHT, &sum2);
+ bench_new(src1, STRIDE, src2, STRIDE, width, HEIGHT, &sum2);
}
}