Commit 727e0cac720 for nodejs
commit 727e0cac720bda03ade94bf664865177b2f219b0
Author: Tamir Duberstein <tamird@gmail.com>
Date: Thu Oct 22 08:58:43 2026 -0400
test: send SNI in CA certificate test
Set servername when connecting to www.nodejs.org so the server selects
its certificate for that hostname. Without SNI, it returns a certificate
that does not cover www.nodejs.org, and the test fails before exercising
CA handling. The nightly internet test is failing with this error [1].
Reproduce the certificate mismatch without Node.js:
openssl s_client -connect www.nodejs.org:443 -noservername \
-verify_hostname www.nodejs.org -verify_return_error </dev/null
This reports "verify error:num=62:Hostname mismatch". Replacing
-noservername with -servername www.nodejs.org succeeds.
[1]: https://github.com/nodejs/node/actions/runs/39084453901
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/66835
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/test/internet/test-tls-add-ca-cert.js b/test/internet/test-tls-add-ca-cert.js
index 2515758ec86..3f76f2b95e7 100644
--- a/test/internet/test-tls-add-ca-cert.js
+++ b/test/internet/test-tls-add-ca-cert.js
@@ -23,6 +23,7 @@ const caCert = loadPEM('ca1-cert');
const opts = {
host: 'www.nodejs.org',
+ servername: 'www.nodejs.org',
port: 443,
rejectUnauthorized: true,
};