Commit 8fcc6f9e429 for woocommerce
commit 8fcc6f9e429d7cb3142f52f1dd2f4dcdab602525
Author: Faisal Ahammad <faisalahammad24@gmail.com>
Date: Thu Nov 19 06:43:41 2026 +0600
fix(product-data): trigger change on variation sale schedule clear (#66263)
diff --git a/plugins/woocommerce/changelog/62270-variation-sale-schedule-clear b/plugins/woocommerce/changelog/62270-variation-sale-schedule-clear
new file mode 100644
index 00000000000..75425350b3f
--- /dev/null
+++ b/plugins/woocommerce/changelog/62270-variation-sale-schedule-clear
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Save cleared sale schedule dates when "Cancel schedule" is clicked on a variation.
diff --git a/plugins/woocommerce/client/legacy/changelog/62270-variation-sale-schedule-clear b/plugins/woocommerce/client/legacy/changelog/62270-variation-sale-schedule-clear
new file mode 100644
index 00000000000..75425350b3f
--- /dev/null
+++ b/plugins/woocommerce/client/legacy/changelog/62270-variation-sale-schedule-clear
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Save cleared sale schedule dates when "Cancel schedule" is clicked on a variation.
diff --git a/plugins/woocommerce/client/legacy/js/admin/meta-boxes-product.js b/plugins/woocommerce/client/legacy/js/admin/meta-boxes-product.js
index bd828ffdc31..f03ce06ead3 100644
--- a/plugins/woocommerce/client/legacy/js/admin/meta-boxes-product.js
+++ b/plugins/woocommerce/client/legacy/js/admin/meta-boxes-product.js
@@ -446,7 +446,15 @@ jQuery( function ( $ ) {
$( this ).hide();
$wrap.find( '.sale_schedule' ).show();
$wrap.find( '.sale_price_dates_fields' ).hide();
- $wrap.find( '.sale_price_dates_fields' ).find( 'input' ).val( '' );
+ // Only fire change for dates that had a value, so cancelling an empty schedule does not mark the variation as changed.
+ $wrap
+ .find( '.sale_price_dates_fields' )
+ .find( 'input' )
+ .filter( function () {
+ return this.value !== '';
+ } )
+ .val( '' )
+ .trigger( 'change' );
return false;
}
diff --git a/plugins/woocommerce/client/legacy/js/admin/test/meta-boxes-product-sale-schedule.test.js b/plugins/woocommerce/client/legacy/js/admin/test/meta-boxes-product-sale-schedule.test.js
new file mode 100644
index 00000000000..974f4304f0b
--- /dev/null
+++ b/plugins/woocommerce/client/legacy/js/admin/test/meta-boxes-product-sale-schedule.test.js
@@ -0,0 +1,79 @@
+describe( 'Product sale schedule cancel', () => {
+ let $;
+
+ beforeAll( () => {
+ // jQuery binds document-ready callbacks on a timer once the document is loaded.
+ jest.useFakeTimers();
+ jest.resetModules();
+
+ $ = require( 'jquery' );
+ global.jQuery = $;
+ global.woocommerce_admin_meta_boxes = { product_types: [] };
+ global._ = { escape: ( value ) => value };
+ [ 'tipTip', 'datepicker', 'sortable', 'selectWoo' ].forEach(
+ ( plugin ) => {
+ $.fn[ plugin ] = function () {
+ return this;
+ };
+ }
+ );
+
+ document.body.innerHTML = `
+ <div id="woocommerce-product-data">
+ <div class="woocommerce_variation">
+ <p class="form-row">
+ <label>
+ <a href="#" class="sale_schedule">Schedule</a>
+ <a href="#" class="cancel_sale_schedule">Cancel schedule</a>
+ </label>
+ </p>
+ <div class="sale_price_dates_fields">
+ <input type="text" class="sale_price_dates_from">
+ <input type="text" class="sale_price_dates_to">
+ </div>
+ </div>
+ </div>
+ `;
+
+ require( '../meta-boxes-product' );
+ jest.runAllTimers();
+ jest.useRealTimers();
+ } );
+
+ afterAll( () => {
+ document.body.innerHTML = '';
+ delete global.jQuery;
+ delete global.woocommerce_admin_meta_boxes;
+ delete global._;
+ } );
+
+ const cancelSchedule = ( from, to ) => {
+ const changed = [];
+ const $inputs = $( '.sale_price_dates_fields input' );
+
+ $inputs.eq( 0 ).val( from );
+ $inputs.eq( 1 ).val( to );
+ $inputs.on( 'change.test', function () {
+ changed.push( this.className );
+ } );
+
+ $( '.cancel_sale_schedule' ).trigger( 'click' );
+ $inputs.off( 'change.test' );
+
+ return { changed, values: $inputs.map( ( i, el ) => el.value ).get() };
+ };
+
+ test( 'does not fire change when the schedule dates are empty', () => {
+ const { changed, values } = cancelSchedule( '', '' );
+
+ expect( changed ).toEqual( [] );
+ expect( values ).toEqual( [ '', '' ] );
+ } );
+
+ test( 'clears saved dates and fires change only for those dates', () => {
+ const { changed, values } = cancelSchedule( '2030-01-01', '' );
+
+ expect( changed ).toEqual( [ 'sale_price_dates_from' ] );
+ expect( values ).toEqual( [ '', '' ] );
+ } );
+} );