Commit 8fd96f4cc46 for nodejs

commit 8fd96f4cc46a59a771fcaebdc3919c4ccf036cf1
Author: Minho Yoo <13810291+irontaek@users.noreply.github.com>
Date:   Wed Oct 14 00:08:10 2026 +0900

    benchmark: throw on invalid type in fs and webstorage

    The default branch of the type switch constructed an Error without
    throwing it, so an unknown type silently benchmarked an undefined
    path instead of failing.

    Assisted-by: a closed-source coding agent
    Signed-off-by: Minho Yoo <13810291+irontaek@users.noreply.github.com>
    PR-URL: https://github.com/nodejs/node/pull/66647
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

diff --git a/benchmark/fs/bench-accessSync.js b/benchmark/fs/bench-accessSync.js
index 0be0ca799d3..b4bc2a06a44 100644
--- a/benchmark/fs/bench-accessSync.js
+++ b/benchmark/fs/bench-accessSync.js
@@ -48,7 +48,7 @@ function main({ n, type, method }) {
       path = tmpdir.resolve(`.non-existing-file-${process.pid}`);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   if (method === 'access') {
diff --git a/benchmark/fs/bench-chmodSync.js b/benchmark/fs/bench-chmodSync.js
index 87b45c06b50..97903db7b93 100644
--- a/benchmark/fs/bench-chmodSync.js
+++ b/benchmark/fs/bench-chmodSync.js
@@ -36,6 +36,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-chownSync.js b/benchmark/fs/bench-chownSync.js
index 18e2bd35d52..bcd83a34264 100644
--- a/benchmark/fs/bench-chownSync.js
+++ b/benchmark/fs/bench-chownSync.js
@@ -49,6 +49,6 @@ function main({ n, type, method }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-existsSync.js b/benchmark/fs/bench-existsSync.js
index f9da2765b13..2b04eeb5167 100644
--- a/benchmark/fs/bench-existsSync.js
+++ b/benchmark/fs/bench-existsSync.js
@@ -27,7 +27,7 @@ function main({ n, type }) {
       path = tmpdir.resolve(`.non-existing-file-${process.pid}`);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/fs/bench-fchmodSync.js b/benchmark/fs/bench-fchmodSync.js
index 4ada8a6f5d8..7023d0d1ff9 100644
--- a/benchmark/fs/bench-fchmodSync.js
+++ b/benchmark/fs/bench-fchmodSync.js
@@ -28,7 +28,7 @@ function main({ n, type }) {
       files = new Array(n).fill(tmpdir.resolve(`.non-existing-file-${Date.now()}`));
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   const fds = files.map((x) => {
diff --git a/benchmark/fs/bench-fsyncSync.js b/benchmark/fs/bench-fsyncSync.js
index fc7ef292667..672d91e369e 100644
--- a/benchmark/fs/bench-fsyncSync.js
+++ b/benchmark/fs/bench-fsyncSync.js
@@ -24,7 +24,7 @@ function main({ n, type }) {
       fd = 1 << 30;
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/fs/bench-linkSync.js b/benchmark/fs/bench-linkSync.js
index ead39c338fe..cb004837d26 100644
--- a/benchmark/fs/bench-linkSync.js
+++ b/benchmark/fs/bench-linkSync.js
@@ -45,6 +45,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-mkdirSync.js b/benchmark/fs/bench-mkdirSync.js
index 1db1c587877..08698b427ee 100644
--- a/benchmark/fs/bench-mkdirSync.js
+++ b/benchmark/fs/bench-mkdirSync.js
@@ -29,7 +29,7 @@ function main({ n, type, recursive }) {
       files = new Array(n).fill(__dirname);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/fs/bench-mkdtempSync.js b/benchmark/fs/bench-mkdtempSync.js
index afb342366bb..1e287493b6f 100644
--- a/benchmark/fs/bench-mkdtempSync.js
+++ b/benchmark/fs/bench-mkdtempSync.js
@@ -27,7 +27,7 @@ function main({ n, type }) {
       prefix = tmpdir.resolve('non-existent', 'foo', 'bar');
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/fs/bench-openSync.js b/benchmark/fs/bench-openSync.js
index b17c0a1e67f..26ea1300b9b 100644
--- a/benchmark/fs/bench-openSync.js
+++ b/benchmark/fs/bench-openSync.js
@@ -33,7 +33,7 @@ function main({ n, type }) {
       path = tmpdir.resolve(`.non-existing-file-${process.pid}`);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   runBench({ n, path });
diff --git a/benchmark/fs/bench-opendirSync.js b/benchmark/fs/bench-opendirSync.js
index f24faa5d5e6..2ea68192b58 100644
--- a/benchmark/fs/bench-opendirSync.js
+++ b/benchmark/fs/bench-opendirSync.js
@@ -25,7 +25,7 @@ function main({ n, type }) {
       files = [tmpdir.resolve(`.non-existing-file-${Date.now()}`)];
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/fs/bench-readSync.js b/benchmark/fs/bench-readSync.js
index a75d1750002..fea37f4c43c 100644
--- a/benchmark/fs/bench-readSync.js
+++ b/benchmark/fs/bench-readSync.js
@@ -38,7 +38,7 @@ function main({ n, type }) {
       fd = 1 << 30;
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   const buffer = Buffer.alloc(bufferSize);
diff --git a/benchmark/fs/bench-readlinkSync.js b/benchmark/fs/bench-readlinkSync.js
index 9b3bbceb42e..57a5611b9f3 100644
--- a/benchmark/fs/bench-readlinkSync.js
+++ b/benchmark/fs/bench-readlinkSync.js
@@ -49,6 +49,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-rmdirSync.js b/benchmark/fs/bench-rmdirSync.js
index 48103439274..71002d41c5a 100644
--- a/benchmark/fs/bench-rmdirSync.js
+++ b/benchmark/fs/bench-rmdirSync.js
@@ -37,6 +37,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-symlinkSync.js b/benchmark/fs/bench-symlinkSync.js
index 92ceb3579a4..c8864527463 100644
--- a/benchmark/fs/bench-symlinkSync.js
+++ b/benchmark/fs/bench-symlinkSync.js
@@ -46,6 +46,6 @@ function main({ n, type }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-timesSync.js b/benchmark/fs/bench-timesSync.js
index 8ea879a63ef..09d5a3891c0 100644
--- a/benchmark/fs/bench-timesSync.js
+++ b/benchmark/fs/bench-timesSync.js
@@ -56,6 +56,6 @@ function main({ n, type, func }) {
       break;
     }
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/fs/bench-unlinkSync.js b/benchmark/fs/bench-unlinkSync.js
index 8b992198c8d..9b134aa678c 100644
--- a/benchmark/fs/bench-unlinkSync.js
+++ b/benchmark/fs/bench-unlinkSync.js
@@ -28,7 +28,7 @@ function main({ n, type }) {
       files = new Array(n).fill(tmpdir.resolve(`.non-existing-file-${Date.now()}`));
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/fs/bench_fdatasyncSync.js b/benchmark/fs/bench_fdatasyncSync.js
index 9aedb0a314f..cd6babadeee 100644
--- a/benchmark/fs/bench_fdatasyncSync.js
+++ b/benchmark/fs/bench_fdatasyncSync.js
@@ -24,7 +24,7 @@ function main({ n, type }) {
       fd = 1 << 30;
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }

   bench.start();
diff --git a/benchmark/webstorage/getItem.js b/benchmark/webstorage/getItem.js
index f92ee0318ff..b82960a6f48 100644
--- a/benchmark/webstorage/getItem.js
+++ b/benchmark/webstorage/getItem.js
@@ -70,6 +70,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/webstorage/removeItem.js b/benchmark/webstorage/removeItem.js
index 0de686d45a3..738ae8a2426 100644
--- a/benchmark/webstorage/removeItem.js
+++ b/benchmark/webstorage/removeItem.js
@@ -70,6 +70,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }
diff --git a/benchmark/webstorage/setItem.js b/benchmark/webstorage/setItem.js
index 5d88a39ef52..fa53bab20df 100644
--- a/benchmark/webstorage/setItem.js
+++ b/benchmark/webstorage/setItem.js
@@ -58,6 +58,6 @@ function main({ n, type }) {
       bench.end(n);
       break;
     default:
-      new Error('Invalid type');
+      throw new Error('Invalid type');
   }
 }