Commit b60ab6c9a4 for ffmpeg
commit b60ab6c9a4583cd4bbdc010b412d598945919da8
Author: romainhedouin <romain.hedouin@epitech.eu>
Date: Thu Oct 15 13:02:31 2026 +0200
avcodec/aacenc_is: compute e01_34 once outside the loop
It only depends on the function arguments, not on the window being
processed. No change in output.
Found during a code review sweep of ffmpeg using an LLM.
Signed-off-by: romainhedouin <romain.hedouin@epitech.eu>
diff --git a/libavcodec/aacenc_is.c b/libavcodec/aacenc_is.c
index 4e711382dc..1446099820 100644
--- a/libavcodec/aacenc_is.c
+++ b/libavcodec/aacenc_is.c
@@ -61,11 +61,11 @@ static struct AACISError aac_is_encoding_err(AACEncContext *s, ChannelElement *c
return is_error;
}
+ float e01_34 = phase*pos_pow34(ener1/ener0);
for (w2 = 0; w2 < sce0->ics.group_len[w]; w2++) {
FFPsyBand *band0 = &s->psy.ch[s->cur_channel+0].psy_bands[(w+w2)*16+g];
FFPsyBand *band1 = &s->psy.ch[s->cur_channel+1].psy_bands[(w+w2)*16+g];
int is_band_type, is_sf_idx = FFMAX(1, sce0->sf_idx[w*16+g]-4);
- float e01_34 = phase*pos_pow34(ener1/ener0);
float maxval, dist_spec_err = 0.0f;
float minthr = FFMIN(band0->threshold, band1->threshold);
for (i = 0; i < sce0->ics.swb_sizes[g]; i++)