Commit b712ab4de1a for php
commit b712ab4de1abd45a913bdd6097cc4633f4bfab51
Author: Weilin Du <weilindu@php.net>
Date: Sat Oct 10 03:22:03 2026 +0800
ext/readline: Remove redundant null checks before free()
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 91cd751559e..3b69131ac7e 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -197,9 +197,7 @@ PHP_FUNCTION(readline_info)
#else
char *copy = strdup(Z_STRVAL_P(value));
rl_line_buffer = copy;
- if (php_readline_custom_line_buffer) {
- free(php_readline_custom_line_buffer);
- }
+ free(php_readline_custom_line_buffer);
php_readline_custom_line_buffer = copy;
#endif
#if !defined(PHP_WIN32)
@@ -272,9 +270,7 @@ PHP_FUNCTION(readline_info)
char *copy = strdup(Z_STRVAL_P(value));
/* XXX: This store would need to be atomic ideally or use a memory barrier */
rl_readline_name = copy;
- if (php_readline_custom_readline_name) {
- free(php_readline_custom_readline_name);
- }
+ free(php_readline_custom_readline_name);
php_readline_custom_readline_name = copy;
}
} else if (zend_string_equals_literal_ci(what, "attempted_completion_over")) {