Commit bda31c596e for qemu.org
commit bda31c596eb561b76acf0835d6cb384c73894f52
Author: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Date: Wed Oct 21 11:12:29 2026 -0700
target/arm: implement get_dump_info sysemu op
For now, we keep the global cpu_get_dump_info symbol defined.
Reviewed-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20261021181244.867840-7-pierrick.bouvier@oss.qualcomm.com
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
diff --git a/target/arm/arch_dump.c b/target/arm/arch_dump.c
index 1dd79849c1..3ce6ba1d68 100644
--- a/target/arm/arch_dump.c
+++ b/target/arm/arch_dump.c
@@ -385,21 +385,14 @@ int arm_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,
return 0;
}
-int cpu_get_dump_info(ArchDumpInfo *info,
- const GuestPhysBlockList *guest_phys_blocks)
+void arm_get_dump_info(const CPUState *cs, ArchDumpInfo *info,
+ const GuestPhysBlockList *guest_phys_blocks)
{
- ARMCPU *cpu;
- CPUARMState *env;
+ const ARMCPU *cpu = ARM_CPU(cs);
+ const CPUARMState *env = &cpu->env;
GuestPhysBlock *block;
hwaddr lowest_addr = ULLONG_MAX;
- if (first_cpu == NULL) {
- return -1;
- }
-
- cpu = ARM_CPU(first_cpu);
- env = &cpu->env;
-
/* Take a best guess at the phys_base. If we get it wrong then crash
* will need '--machdep phys_offset=<phys-offset>' added to its command
* line, which isn't any worse than assuming we can use zero, but being
@@ -435,7 +428,16 @@ int cpu_get_dump_info(ArchDumpInfo *info,
*/
info->d_endian = (env->cp15.sctlr_el[1] & SCTLR_EE) != 0
? ELFDATA2MSB : ELFDATA2LSB;
+}
+
+int cpu_get_dump_info(ArchDumpInfo *info,
+ const GuestPhysBlockList *guest_phys_blocks)
+{
+ if (first_cpu == NULL) {
+ return -1;
+ }
+ arm_get_dump_info(first_cpu, info, guest_phys_blocks);
return 0;
}
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 81ec1ce21c..7bf0c5e74f 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -2569,6 +2569,7 @@ static const struct SysemuCPUOps arm_sysemu_ops = {
.asidx_from_attrs = arm_asidx_from_attrs,
.write_elf32_note = arm_cpu_write_elf32_note,
.write_elf64_note = arm_cpu_write_elf64_note,
+ .get_dump_info = arm_get_dump_info,
.internal_is_big_endian = arm_cpu_internal_is_big_endian,
.legacy_vmsd = &vmstate_arm_cpu,
};
diff --git a/target/arm/internals.h b/target/arm/internals.h
index e849e357cf..8c1c6e7c44 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -438,6 +438,8 @@ int arm_cpu_mmu_index(CPUState *cs, bool ifetch);
#endif /* CONFIG_TCG */
extern const struct SemihostingCPUOps arm_semihosting_ops;
+void arm_get_dump_info(const CPUState *cs, ArchDumpInfo *info,
+ const GuestPhysBlockList *guest_phys_blocks);
typedef enum ARMFPRounding {
FPROUNDING_TIEEVEN,