Commit cdd06876dac for nodejs
commit cdd06876dac5f6acbb938e7a583e73a540934898
Author: Ved Chaudhari <84765263+vedchaudhari@users.noreply.github.com>
Date: Thu Nov 19 09:10:55 2026 +0530
fs: restore stack traces of fs/promises stat permission errors
Since stat() started going through raceWithSignal(), permission
errors from fsPromises.stat() have had no stack frames. The binding
rejects them right away, and raceWithSignal() returned that promise
from an async function without awaiting it, so nothing was awaiting
it yet when the stack was captured.
Return the promise as is when there is no signal, so stat() awaits
it directly again.
Refs: https://github.com/nodejs/node/pull/63143
Signed-off-by: vedchaudhari <vedc2853@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/67525
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index 5f9765d0cf3..9696012b0c2 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -1218,8 +1218,12 @@ function rejectWithReason(signal, reject) {
};
}
-async function raceWithSignal(opPromise, signal) {
+function raceWithSignal(opPromise, signal) {
if (!signal) return opPromise;
+ return raceWithAbortSignal(opPromise, signal);
+}
+
+async function raceWithAbortSignal(opPromise, signal) {
const { promise: abortPromise, reject } = PromiseWithResolvers();
// eslint-disable-next-line no-unused-vars
using _ = EventEmitter.addAbortListener(signal,
diff --git a/test/parallel/test-permission-fs-promises-stack-trace.js b/test/parallel/test-permission-fs-promises-stack-trace.js
index 7160473173e..7a9999c979a 100644
--- a/test/parallel/test-permission-fs-promises-stack-trace.js
+++ b/test/parallel/test-permission-fs-promises-stack-trace.js
@@ -16,19 +16,21 @@ const { status, stderr } = spawnSync(
'-e',
`
const assert = require('assert');
- const { readFile, writeFile, appendFile } = require('fs/promises');
+ const { readFile, writeFile, appendFile, stat } = require('fs/promises');
const target = ${JSON.stringify(tmpdir.resolve('file'))};
function readCaller() { return readFile(target); }
function writeCaller() { return writeFile(target, 'data'); }
function appendCaller() { return appendFile(target, 'data'); }
async function awaitAppendCaller() { await appendFile(target, 'data'); }
+ async function awaitStatCaller() { await stat(target); }
const cases = [
[readCaller, /at readCaller /],
[writeCaller, /at writeCaller /],
[appendCaller, /at appendCaller /],
[awaitAppendCaller, /at awaitAppendCaller /],
+ [awaitStatCaller, /at async awaitStatCaller /],
];
let checked = 0;
for (const [caller, stack] of cases) {