Commit dd23cd248c5 for nodejs
commit dd23cd248c57daa2eedd75101544b582e7162b00
Author: Lily Chen <chlily@google.com>
Date: Sat Nov 14 16:25:02 2026 -0500
crypto: use const STACK_OF(SSL_CIPHER)* for SSL_get_ciphers
BoringSSL is updating SSL_get_ciphers and SSL_CTX_get_ciphers to return
const STACK_OF(SSL_CIPHER)* instead of a non-const pointer. Declare the
local ciphers variable in SSLPointer::getCiphers as const so it builds
cleanly against both OpenSSL and BoringSSL.
Refs: https://crbug.com/550501994
Signed-off-by: Lily Chen <chlily@google.com>
PR-URL: https://github.com/nodejs/node/pull/67443
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/deps/ncrypto/ncrypto.cc b/deps/ncrypto/ncrypto.cc
index 8fcabdf00d0..aff6f873ec0 100644
--- a/deps/ncrypto/ncrypto.cc
+++ b/deps/ncrypto/ncrypto.cc
@@ -5213,7 +5213,7 @@ SSLPointer SSLPointer::New(const SSLCtxPointer& ctx) {
void SSLPointer::getCiphers(std::function<void(const char*)> cb) const {
if (!ssl_) return;
- STACK_OF(SSL_CIPHER)* ciphers = SSL_get_ciphers(get());
+ const STACK_OF(SSL_CIPHER)* ciphers = SSL_get_ciphers(get());
// TLSv1.3 ciphers aren't listed by EVP. There are only 5, we could just
// document them, but since there are only 5, easier to just add them manually