Commit 0fa55fb for jssip.net
commit 0fa55fba6657c2ffac6aefc8c8985cbcb6ef7a00
Author: José Luis Millán <jmillan@aliax.net>
Date: Fri Jan 9 11:38:32 2026 +0100
run lint from npm-scripts.js rather than gulpfile.js
diff --git a/gulpfile.js b/gulpfile.js
index 15d6e2a..f698a85 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -8,8 +8,6 @@ const exec = require('child_process').exec;
const gulp = require('gulp');
const expect = require('gulp-expect-file');
const nodeunit = require('gulp-nodeunit-runner');
-const eslint = require('gulp-eslint');
-const plumber = require('gulp-plumber');
const log = require('fancy-log');
const colors = require('ansi-colors');
@@ -20,16 +18,6 @@ const EXPECT_OPTIONS = {
checkRealFile : true
};
-gulp.task('lint', function()
-{
- const src = [ 'gulpfile.js', '.eslintrc.js', 'lib/**/*.js', 'test/**/*.js' ];
-
- return gulp.src(src)
- .pipe(plumber())
- .pipe(eslint())
- .pipe(eslint.format());
-});
-
gulp.task('test', function()
{
// var src = 'test/*.js';
@@ -80,6 +68,6 @@ gulp.task('grammar', function(cb)
gulp.task('devel', gulp.series('grammar'));
-gulp.task('dist', gulp.series('lint', 'test'));
+gulp.task('dist', gulp.series('test'));
gulp.task('default', gulp.series('dist'));
diff --git a/npm-scripts.js b/npm-scripts.js
index 1fe0aff..5620f12 100644
--- a/npm-scripts.js
+++ b/npm-scripts.js
@@ -4,6 +4,8 @@ const { version } = require('./package.json');
const task = process.argv.slice(2).join(' ');
+const ESLINT_PATHS = [ 'gulpfile.js', 'lib', 'test' ].join(' ');
+
// eslint-disable-next-line no-console
console.log(`npm-scripts.js [INFO] running task "${task}"`);
@@ -11,25 +13,26 @@ switch (task)
{
case 'lint':
{
- execute('gulp lint');
+ lint();
break;
}
case 'test':
{
- execute('gulp test');
+ executeCmd('gulp test');
break;
}
case 'release':
{
- execute('gulp');
- execute(`git commit -am '${version}'`);
- execute(`git tag -a ${version} -m '${version}'`);
- execute('git push origin master && git push origin --tags');
- execute('npm publish');
+ lint();
+ executeCmd('gulp');
+ executeCmd(`git commit -am '${version}'`);
+ executeCmd(`git tag -a ${version} -m '${version}'`);
+ executeCmd('git push origin master && git push origin --tags');
+ executeCmd('npm publish');
// eslint-disable-next-line no-console
console.log('update tryit-jssip and JsSIP website');
@@ -43,7 +46,16 @@ switch (task)
}
}
-function execute(command)
+function lint()
+{
+ logInfo('lint()');
+
+ executeCmd(
+ `eslint --max-warnings 0 ${ESLINT_PATHS}`
+ );
+}
+
+function executeCmd(command)
{
// eslint-disable-next-line no-console
console.log(`npm-scripts.js [INFO] executing command: ${command}`);
@@ -57,3 +69,16 @@ function execute(command)
process.exit(1);
}
}
+
+function logInfo(...args)
+{
+ // eslint-disable-next-line no-console
+ console.log(`npm-scripts.mjs \x1b[36m[INFO] [${task}]\x1b[0m`, ...args);
+}
+
+// eslint-disable-next-line no-unused-vars
+function logWarn(...args)
+{
+ // eslint-disable-next-line no-console
+ console.warn(`npm-scripts.mjs \x1b[33m[WARN] [${task}]\x1b\0m`, ...args);
+}
diff --git a/package.json b/package.json
index 87a7051..f693263 100644
--- a/package.json
+++ b/package.json
@@ -38,10 +38,8 @@
"eslint": "^5.16.0",
"fancy-log": "^1.3.3",
"gulp": "^4.0.2",
- "gulp-eslint": "^5.0.0",
"gulp-expect-file": "^1.0.2",
"gulp-nodeunit-runner": "^0.2.2",
- "gulp-plumber": "^1.2.1",
"pegjs": "^0.7.0"
},
"scripts": {