Commit 10fb64fed70 for php.net
commit 10fb64fed7016c6beb0aad1e39afc5e893277fa1
Author: Arshid <arshidkv12@gmail.com>
Date: Thu Feb 5 23:53:18 2026 +0530
ext/readline: readline_read_history/readline_write_history returning a boolean value using RETURN_BOOL (#21140)
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 838c74da86c..61129194db2 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -393,13 +393,9 @@ PHP_FUNCTION(readline_read_history)
RETURN_FALSE;
}
- /* XXX from & to NYI */
- if (read_history(arg)) {
- /* If filename is NULL, then read from `~/.history' */
- RETURN_FALSE;
- } else {
- RETURN_TRUE;
- }
+ /* XXX from & to NYI
+ If filename is NULL, then read from `~/.history' */
+ RETURN_BOOL(!read_history(arg));
}
/* }}} */
@@ -417,11 +413,7 @@ PHP_FUNCTION(readline_write_history)
RETURN_FALSE;
}
- if (write_history(arg)) {
- RETURN_FALSE;
- } else {
- RETURN_TRUE;
- }
+ RETURN_BOOL(!write_history(arg));
}
/* }}} */