Commit 16485b23ce for wordpress.org
commit 16485b23ce81091e4804f09d7391a04789c5f57b
Author: davidbaumwald <davidbaumwald@git.wordpress.org>
Date: Tue Nov 4 14:01:34 2025 +0000
Command Palette: Use `HTML_Tag_Processor` to get the menu label when enqueueing assets, not regex.
`HTML_Tag_Processor` is more better.
Follow-up to [61022].
Props dmsnell, cbravobernal.
Fixes #64196.
Built from https://develop.svn.wordpress.org/trunk@61126
git-svn-id: http://core.svn.wordpress.org/trunk@60462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
diff --git a/wp-includes/script-loader.php b/wp-includes/script-loader.php
index 87a8339ec8..4e73b50d4a 100644
--- a/wp-includes/script-loader.php
+++ b/wp-includes/script-loader.php
@@ -3442,9 +3442,11 @@ function wp_enqueue_command_palette_assets() {
}
// Remove all HTML tags and their contents.
- $menu_label = $menu_item[0];
- while ( preg_match( '/<[^>]*>/', $menu_label ) ) {
- $menu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $menu_label );
+ $processor = new WP_HTML_Tag_Processor( $menu_item[0] );
+ while ( $processor->next_token() ) {
+ if ( '#text' === $processor->get_token_name() ) {
+ $menu_label .= $processor->get_modifiable_text();
+ }
}
$menu_label = trim( $menu_label );
$menu_url = '';
@@ -3471,9 +3473,12 @@ function wp_enqueue_command_palette_assets() {
}
// Remove all HTML tags and their contents.
- $submenu_label = $submenu_item[0];
- while ( preg_match( '/<[^>]*>/', $submenu_label ) ) {
- $submenu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $submenu_label );
+ $processor = new WP_HTML_Tag_Processor( $submenu_item[0] );
+ $submenu_label = '';
+ while ( $processor->next_token() ) {
+ if ( '#text' === $processor->get_token_name() ) {
+ $submenu_label .= $processor->get_modifiable_text();
+ }
}
$submenu_label = trim( $submenu_label );
$submenu_url = '';
diff --git a/wp-includes/version.php b/wp-includes/version.php
index 019c5aa4f8..3300e39cf3 100644
--- a/wp-includes/version.php
+++ b/wp-includes/version.php
@@ -16,7 +16,7 @@
*
* @global string $wp_version
*/
-$wp_version = '6.9-beta2-61125';
+$wp_version = '6.9-beta2-61126';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.