Commit 2142689d92 for qemu.org

commit 2142689d92ca87b53ad1a0a8d48f439baf17e13a
Author: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Date:   Mon Jul 20 10:06:04 2026 +0200

    hw/misc/applesmc: Fix a typo setting MSSD key

    In commit 1ddda5cd364 we meant to set MSSD=3, but due
    to a typo we ended setting MSSD=0. Convert the two other
    NATJ and MSSP keys to use hexadecimal notation to avoid
    similar copy/paste typos.

    Cc: qemu-stable@nongnu.org
    Fixes: 1ddda5cd364 ("AppleSMC device emulation")
    Reported-by: Matthew Jackson <matthew@pq.io>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
    Reviewed-by: Alexander Graf <agraf@csgraf.de>
    Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
    Message-Id: <20260720115336.75063-1-philmd@oss.qualcomm.com>

diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index fd96f5f245..d004e8b443 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -333,9 +333,9 @@ static void applesmc_isa_realize(DeviceState *dev, Error **errp)
     applesmc_add_key(s, "REV ", 6, "\x01\x13\x0f\x00\x00\x03");
     applesmc_add_key(s, "OSK0", 32, s->osk);
     applesmc_add_key(s, "OSK1", 32, s->osk + 32);
-    applesmc_add_key(s, "NATJ", 1, "\0");
-    applesmc_add_key(s, "MSSP", 1, "\0");
-    applesmc_add_key(s, "MSSD", 1, "\0x3");
+    applesmc_add_key(s, "NATJ", 1, "\x00");
+    applesmc_add_key(s, "MSSP", 1, "\x00");
+    applesmc_add_key(s, "MSSD", 1, "\x03");
 }

 static void applesmc_unrealize(DeviceState *dev)