Commit 37ee17eebb for qemu.org
commit 37ee17eebb93eb485fc122452a4c7e9202a8b449
Author: Zhao Liu <zhao1.liu@intel.com>
Date: Sun Nov 10 23:09:01 2024 +0800
hw/core/machine-smp: Fix error message parameter
In the loop checking smp cache support, the error message should report
the current cache level and type.
Fix the parameter of error_setg() to ensure it reports the correct cache
level and type.
Resolves: Coverity CID 1565391
Fixes: f35c0221fef8 ("hw/core: Check smp cache topology support for machine")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/20241110150901.130647-3-zhao1.liu@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
index b87637c78f..b954eb8490 100644
--- a/hw/core/machine-smp.c
+++ b/hw/core/machine-smp.c
@@ -317,7 +317,7 @@ bool machine_parse_smp_cache(MachineState *ms,
!mc->smp_props.cache_supported[props->cache]) {
error_setg(errp,
"%s cache topology not supported by this machine",
- CacheLevelAndType_str(node->value->cache));
+ CacheLevelAndType_str(props->cache));
return false;
}