Commit 400b3633ff for qemu.org
commit 400b3633ff1d743bca95eb1cfde16a4682e16739
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Wed Mar 11 00:20:36 2026 +0100
gdbstub: Have scripts/feature_to_c.py generate more verbose output
Make the structure field names explicit, so it is easier
to figure what is what when reviewing multiple entries.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Tested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Link: https://lore.kernel.org/qemu-devel/20260310232045.58440-9-philmd@linaro.org
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/scripts/feature_to_c.py b/scripts/feature_to_c.py
index 3aa62fb895..1329695ad0 100644
--- a/scripts/feature_to_c.py
+++ b/scripts/feature_to_c.py
@@ -85,13 +85,16 @@ def writeliteral(indent, bytes):
num_regs = max(regnums) - base_reg + 1 if len(regnums) else 0
sys.stdout.write(' {\n')
- writeliteral(8, bytes(os.path.basename(input), 'utf-8'))
+ sys.stdout.write(' .xmlname = ')
+ writeliteral(0, bytes(os.path.basename(input), 'utf-8'))
sys.stdout.write(',\n')
- writeliteral(8, read)
+ sys.stdout.write(' .xml = \n')
+ writeliteral(12, read)
sys.stdout.write(',\n')
- writeliteral(8, bytes(feature_name, 'utf-8'))
+ sys.stdout.write(' .name = ')
+ writeliteral(0, bytes(feature_name, 'utf-8'))
sys.stdout.write(',\n')
- sys.stdout.write(f' (const char * const [{num_regs}]) {{\n')
+ sys.stdout.write(f' .regs = (const char * const [{num_regs}]) {{\n')
for index, regname in enumerate(regnames):
sys.stdout.write(f' [{regnums[index] - base_reg}] =\n')
@@ -99,7 +102,7 @@ def writeliteral(indent, bytes):
sys.stdout.write(',\n')
sys.stdout.write( ' },\n')
- sys.stdout.write(f' {num_regs},\n')
+ sys.stdout.write(f' .num_regs = {num_regs},\n')
sys.stdout.write( ' },\n')
sys.stdout.write(' { NULL }\n};\n')