Commit 50584f02bc for qemu.org
commit 50584f02bce4516550ad080687f0cb47f8e193e1
Author: Richard Henderson <richard.henderson@linaro.org>
Date: Sat Apr 25 18:24:37 2026 +1000
fpu: Return struct from float8_e4m3_unpack_canonical
Inline float8_e4m3_unpack_raw at the same time.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index c1d0140484..c1b03f30ab 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -646,11 +646,6 @@ static FloatParts64 unpack_raw64(const FloatFmt *fmt, uint64_t raw)
};
}
-static void QEMU_FLATTEN float8_e4m3_unpack_raw(FloatParts64 *p, float8_e4m3 f)
-{
- *p = unpack_raw64(&float8_e4m3_params, f);
-}
-
static void QEMU_FLATTEN float8_e5m2_unpack_raw(FloatParts64 *p, float8_e5m2 f)
{
*p = unpack_raw64(&float8_e5m2_params, f);
@@ -1475,11 +1470,11 @@ static FloatParts64 float4_e2m1_unpack_canonical(float4_e2m1 f, float_status *s)
return p;
}
-static void float8_e4m3_unpack_canonical(FloatParts64 *p, float8_e4m3 f,
- float_status *s)
+static FloatParts64 float8_e4m3_unpack_canonical(float8_e4m3 f, float_status *s)
{
- float8_e4m3_unpack_raw(p, f);
- parts64_canonicalize(p, s, &float8_e4m3_params);
+ FloatParts64 p = unpack_raw64(&float8_e4m3_params, f);
+ parts64_canonicalize(&p, s, &float8_e4m3_params);
+ return p;
}
static void float8_e5m2_unpack_canonical(FloatParts64 *p, float8_e5m2 f,
@@ -2701,9 +2696,7 @@ float8_e4m3 float4_e2m1_to_float8_e4m3(float4_e2m1 a, float_status *s)
bfloat16 float8_e4m3_to_bfloat16(float8_e4m3 a, float_status *s)
{
- FloatParts64 p;
-
- float8_e4m3_unpack_canonical(&p, a, s);
+ FloatParts64 p = float8_e4m3_unpack_canonical(a, s);
parts64_float_to_float(&p, s);
return bfloat16_round_pack_canonical(&p, s);
}