Commit 520ca2d20e for openssl.org
commit 520ca2d20e5f3e478d967ee0a551b259a12bb995
Author: Bob Beck <beck@openssl.org>
Date: Mon Sep 15 11:52:44 2025 -0600
Don't return a value we never check from indent_printf()
Coverity notices it could overflow, since we don't use this
don't bother returning it
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/28553)
diff --git a/apps/storeutl.c b/apps/storeutl.c
index f8ebde4448..bb489d6d9b 100644
--- a/apps/storeutl.c
+++ b/apps/storeutl.c
@@ -328,25 +328,14 @@ int storeutl_main(int argc, char *argv[])
return ret;
}
-static int indent_printf(int indent, BIO *bio, const char *format, ...)
+static void indent_printf(int indent, BIO *bio, const char *format, ...)
{
va_list args;
- int ret, vret;
-
- ret = BIO_printf(bio, "%*s", indent, "");
- if (ret < 0)
- return ret;
+ BIO_printf(bio, "%*s", indent, "");
va_start(args, format);
- vret = BIO_vprintf(bio, format, args);
+ BIO_vprintf(bio, format, args);
va_end(args);
-
- if (vret < 0)
- return vret;
- if (vret > INT_MAX - ret)
- return INT_MAX;
-
- return ret + vret;
}
static int process(const char *uri, const UI_METHOD *uimeth, PW_CB_DATA *uidata,