Commit 540be542d1 for qemu.org
commit 540be542d109ca00944c8229cc9be5b9582f9f60
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Sun Dec 21 16:20:48 2025 +0100
monitor/hmp: Inline ld[uw,l,q]_p() calls in memory_dump()
Remove the last target-specificity in this file.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <20251229231546.50604-6-philmd@linaro.org>
diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
index 7c8bddabba..e782259c3e 100644
--- a/monitor/hmp-cmds-target.c
+++ b/monitor/hmp-cmds-target.c
@@ -129,6 +129,7 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
uint64_t v;
CPUState *cs = mon_get_cpu(mon);
const unsigned int addr_width = is_physical ? 8 : (target_long_bits() * 2);
+ const bool big_endian = target_big_endian();
if (!cs && (format == 'i' || !is_physical)) {
monitor_printf(mon, "Can not dump without CPU\n");
@@ -192,13 +193,13 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
v = ldub_p(buf + i);
break;
case 2:
- v = lduw_p(buf + i);
+ v = (big_endian ? lduw_be_p : lduw_le_p)(buf + i);
break;
case 4:
- v = (uint32_t)ldl_p(buf + i);
+ v = (uint32_t)(big_endian ? ldl_be_p : ldl_le_p)(buf + i);
break;
case 8:
- v = ldq_p(buf + i);
+ v = (big_endian ? ldq_be_p : ldq_le_p)(buf + i);
break;
}
monitor_printf(mon, " ");