Commit 6316ced6d7d for php.net
commit 6316ced6d7dc8c4b816aa471a46a2369b1d2cb6e
Author: Louis-Arnaud <la.catoire@gmail.com>
Date: Sun Aug 23 16:10:36 2026 +0200
standard: Fix parameter name in the convert_uudecode() warning (#23306)
The warning names $data, but the parameter has been declared as $string
since the stub was introduced, so following the message and calling
convert_uudecode(data: ...) raises Error: Unknown named parameter $data.
The message is a literal rather than a generated one, which is why it did
not follow the parameter. Three tests pinning the old wording are updated.
Co-authored-by: lacatoire <ext-lacatoire@cenef.fr>
diff --git a/ext/standard/tests/strings/bug67252.phpt b/ext/standard/tests/strings/bug67252.phpt
index bd758a1c79f..60ae319f76d 100644
--- a/ext/standard/tests/strings/bug67252.phpt
+++ b/ext/standard/tests/strings/bug67252.phpt
@@ -8,5 +8,5 @@
?>
--EXPECTF--
-Warning: convert_uudecode(): Argument #1 ($data) is not a valid uuencoded string in %s on line %d
+Warning: convert_uudecode(): Argument #1 ($string) is not a valid uuencoded string in %s on line %d
bool(false)
diff --git a/ext/standard/tests/strings/uuencode.phpt b/ext/standard/tests/strings/uuencode.phpt
index d03c2b1bf0f..82ded416576 100644
--- a/ext/standard/tests/strings/uuencode.phpt
+++ b/ext/standard/tests/strings/uuencode.phpt
@@ -29,9 +29,9 @@
"
string(22) "not very sophisticated"
-Warning: convert_uudecode(): Argument #1 ($data) is not a valid uuencoded string in %s on line %d
+Warning: convert_uudecode(): Argument #1 ($string) is not a valid uuencoded string in %s on line %d
bool(false)
-Warning: convert_uudecode(): Argument #1 ($data) is not a valid uuencoded string in %s on line %d
+Warning: convert_uudecode(): Argument #1 ($string) is not a valid uuencoded string in %s on line %d
bool(false)
Done
diff --git a/ext/standard/uuencode.c b/ext/standard/uuencode.c
index af70e3a2aa2..6dc2848fec0 100644
--- a/ext/standard/uuencode.c
+++ b/ext/standard/uuencode.c
@@ -222,7 +222,7 @@ PHP_FUNCTION(convert_uudecode)
ZEND_PARSE_PARAMETERS_END();
if ((dest = php_uudecode(ZSTR_VAL(src), ZSTR_LEN(src))) == NULL) {
- php_error_docref(NULL, E_WARNING, "Argument #1 ($data) is not a valid uuencoded string");
+ php_error_docref(NULL, E_WARNING, "Argument #1 ($string) is not a valid uuencoded string");
RETURN_FALSE;
}