Commit 7a6665350b for qemu.org
commit 7a6665350b3049e2813e22603c03eda0d2dfe680
Author: Markus Armbruster <armbru@redhat.com>
Date: Fri Nov 21 13:14:27 2025 +0100
tap-solaris: Use error_setg_file_open() for better error messages
Error messages change from
Can't open /dev/ip (actually /dev/udp)
Can't open /dev/tap
Can't open /dev/tap (2)
to
Could not open '/dev/udp': REASON
Could not open '/dev/tap': REASON
where REASON is the value of strerror(errno).
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Message-ID: <20251121121438.1249498-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/net/tap-solaris.c b/net/tap-solaris.c
index 75397e6c54..faf7922ea8 100644
--- a/net/tap-solaris.c
+++ b/net/tap-solaris.c
@@ -87,13 +87,13 @@ static int tap_alloc(char *dev, size_t dev_size, Error **errp)
ip_fd = RETRY_ON_EINTR(open("/dev/udp", O_RDWR, 0));
if (ip_fd < 0) {
- error_setg(errp, "Can't open /dev/ip (actually /dev/udp)");
+ error_setg_file_open(errp, errno, "/dev/udp");
return -1;
}
tap_fd = RETRY_ON_EINTR(open("/dev/tap", O_RDWR, 0));
if (tap_fd < 0) {
- error_setg(errp, "Can't open /dev/tap");
+ error_setg_file_open(errp, errno, "/dev/tap");
return -1;
}
@@ -107,7 +107,7 @@ static int tap_alloc(char *dev, size_t dev_size, Error **errp)
if_fd = RETRY_ON_EINTR(open("/dev/tap", O_RDWR, 0));
if (if_fd < 0) {
- error_setg(errp, "Can't open /dev/tap (2)");
+ error_setg_file_open(errp, errno, "/dev/tap");
return -1;
}
if(ioctl(if_fd, I_PUSH, "ip") < 0){