Commit 8884f5ca for libheif
commit 8884f5ca92fd9c6f6cdab0144155d9e84b237640
Author: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
Date: Mon Jan 26 15:39:53 2026 +0100
Fix passing compiler options to preprocessor
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e593f065..eec058cc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -35,19 +35,19 @@ endif()
if(NOT MSVC)
# cmake 3.24 introduces this variable, but for backward compatibility, we set it explicitly
if (CMAKE_COMPILE_WARNING_AS_ERROR)
- add_definitions(-Werror)
+ add_compile_options(-Werror)
endif ()
- add_definitions(-Wall)
- add_definitions(-Wsign-compare)
- add_definitions(-Wconversion)
- add_definitions(-Wno-sign-conversion)
- add_definitions(-Wno-error=conversion)
- add_definitions(-Wno-error=unused-parameter)
- add_definitions(-Wno-error=deprecated-declarations)
+ add_compile_options(-Wall)
+ add_compile_options(-Wsign-compare)
+ add_compile_options(-Wconversion)
+ add_compile_options(-Wno-sign-conversion)
+ add_compile_options(-Wno-error=conversion)
+ add_compile_options(-Wno-error=unused-parameter)
+ add_compile_options(-Wno-error=deprecated-declarations)
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- add_definitions(-Wno-error=tautological-compare)
- add_definitions(-Wno-error=tautological-constant-out-of-range-compare)
+ add_compile_options(-Wno-error=tautological-compare)
+ add_compile_options(-Wno-error=tautological-constant-out-of-range-compare)
endif ()
endif()
@@ -67,7 +67,7 @@ option(BUILD_SHARED_LIBS "Build shared libraries" ON)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG(-Wno-error=potentially-evaluated-expression has_potentially_evaluated_expression)
if (has_potentially_evaluated_expression)
- add_definitions(-Wno-error=potentially-evaluated-expression)
+ add_compile_options(-Wno-error=potentially-evaluated-expression)
endif()
LIST (APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/modules")