Commit 89e3cbb474 for woocommerce
commit 89e3cbb47425462d3afc5e861257af2f6858df8e
Author: Sam Seay <samueljseay@gmail.com>
Date: Wed Feb 25 22:06:35 2026 +1300
Add blocks-specific JS lint instructions to dev-cycle skill (#63442)
The plugin-level .eslintignore excludes client/blocks/, so
lint:changes:branch:js silently skips blocks files. Document
that blocks changes need the blocks package lint command to
catch eslint and prettier issues before CI.
diff --git a/.ai/skills/woocommerce-dev-cycle/code-quality.md b/.ai/skills/woocommerce-dev-cycle/code-quality.md
index 5caa198266..1f87b9443d 100644
--- a/.ai/skills/woocommerce-dev-cycle/code-quality.md
+++ b/.ai/skills/woocommerce-dev-cycle/code-quality.md
@@ -80,6 +80,16 @@ This command:
- Identifies code style and potential issues
- Does not modify files
+**Important:** The plugin-level `.eslintignore` excludes `client/blocks/`, so `lint:changes:branch:js` will not catch eslint or prettier issues in blocks code. For blocks changes, also run the blocks package lint:
+
+```bash
+# Check blocks JS/TS (includes prettier via eslint plugin)
+pnpm --filter=@woocommerce/block-library lint:js
+
+# Auto-fix blocks JS/TS issues
+pnpm --filter=@woocommerce/block-library lint:js-fix
+```
+
For detailed JavaScript/TypeScript linting configuration and patterns, see `client/admin/CLAUDE.md`.
## Markdown Linting
@@ -198,6 +208,7 @@ Before committing your changes:
- [ ] Run `pnpm run lint:changes:branch:php`
- [ ] Run `pnpm run lint:php:fix` if issues found
- [ ] Run `pnpm run lint:changes:branch:js` if you modified JS files
+- [ ] Run `pnpm --filter=@woocommerce/block-library lint:js-fix` if you modified blocks JS/TS files
- [ ] Review all automatic fixes with `git diff`
- [ ] Address any remaining issues that can't be auto-fixed
- [ ] Run tests to ensure fixes didn't break functionality