Commit 953f72dee0 for woocommerce
commit 953f72dee02430e5c6e18b6495b65765dd4c4432
Author: Shahed <125728402+dev-shahed@users.noreply.github.com>
Date: Tue Jan 27 20:58:01 2026 +0600
Prevent undefined index when connecting pages without an id (#61904)
diff --git a/plugins/woocommerce/changelog/61904-fix-null-array-key b/plugins/woocommerce/changelog/61904-fix-null-array-key
new file mode 100644
index 0000000000..b09a73161e
--- /dev/null
+++ b/plugins/woocommerce/changelog/61904-fix-null-array-key
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Prevent undefined index notices when connecting admin pages without an `id`.
\ No newline at end of file
diff --git a/plugins/woocommerce/src/Admin/PageController.php b/plugins/woocommerce/src/Admin/PageController.php
index 0f61e3b274..f17e0bf125 100644
--- a/plugins/woocommerce/src/Admin/PageController.php
+++ b/plugins/woocommerce/src/Admin/PageController.php
@@ -116,7 +116,7 @@ class PageController {
*/
$options = apply_filters( 'woocommerce_navigation_connect_page_options', $options );
- // @todo check for null ID, or collision.
+ // In the future, we should consider check for collision, but keep in mind that the current behavior is: the later call silently overwrites the earlier one.
$id = $options['id'] ?? null;
if ( is_string( $id ) && '' !== $id ) {