Commit b64a5f5351 for qemu.org

commit b64a5f5351314a21b2f2b753a90f492d144e3b8b
Author: Peter Maydell <peter.maydell@linaro.org>
Date:   Mon Mar 23 09:51:01 2026 +0000

    tests/qtest/arm-cpu-features: Fix thinko in g_strdup_printf() call

    In commit 62272f9f8891 we changed some uses of fixed char arrays
    to call g_strdup_printf() instead. In one place I made a silly
    error where in changing
      sprintf(name, "fmt string", ...)
    to
      name = g_strdup_printf("fmt string", ...)
    I forgot to delete "name" from the argument list.

    Luckily Coverity spotted this (as CID 1645771) because at this
    point "name" is NULL and passing g_strdup_printf() a NULL first
    argument is not valid.

    We didn't notice the mistake in testing or CI because this bit of
    code is only run if on an AArch64 host with KVM and SVE available.

    Correct the error by removing the stray function argument.

    Fixes: 62272f9f8891 ("tests/qtest/arm-cpu-features: Use g_strdup_printf() instead of char arrays")
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
    Reviewed-by: Cédric Le Goater <clg@redhat.com>
    Message-id: 20260317111121.2062455-1-peter.maydell@linaro.org

diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
index 5444e4d40b..bbdd89a81d 100644
--- a/tests/qtest/arm-cpu-features.c
+++ b/tests/qtest/arm-cpu-features.c
@@ -612,7 +612,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
              * we need at least one vector length enabled.
              */
             vq = __builtin_ffsll(vls);
-            name = g_strdup_printf(name, "sve%u", vq * 128);
+            name = g_strdup_printf("sve%u", vq * 128);
             error = g_strdup_printf("cannot disable %s", name);
             assert_error(qts, "host", error, "{ %s: false }", name);
             g_free(error);