Commit d21db261c1 for openssl.org
commit d21db261c1d16c1eca54b5176675152ec67d9a56
Author: Abhinav Agarwal <abhinavagarwal1996@gmail.com>
Date: Sun Mar 22 10:45:53 2026 -0700
quic: fix off-by-one in QUIC_MAX_MAX_ACK_DELAY
Should be 2^14-1 (16383) per RFC 9000 s. 18.2, not 2^14 (16384).
Fixes: 35dc6c353bfe ("QUIC: Make more transport parameters configurable")
Signed-off-by: Abhinav Agarwal <abhinavagarwal1996@gmail.com>
Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
MergeDate: Tue Mar 24 17:55:50 2026
(Merged from https://github.com/openssl/openssl/pull/30531)
diff --git a/include/internal/quic_types.h b/include/internal/quic_types.h
index 944b430ae9..984a9774da 100644
--- a/include/internal/quic_types.h
+++ b/include/internal/quic_types.h
@@ -103,7 +103,7 @@ int ossl_quic_gen_rand_conn_id(OSSL_LIB_CTX *libctx, size_t len,
#define QUIC_MAX_ACK_DELAY_EXP 20
#define QUIC_DEFAULT_MAX_ACK_DELAY 25
-#define QUIC_MAX_MAX_ACK_DELAY 16384
+#define QUIC_MAX_MAX_ACK_DELAY 16383 /* RFC 9000 s. 18.2 */
#define QUIC_MIN_ACTIVE_CONN_ID_LIMIT 2