Commit f811e8ba6c for qemu.org
commit f811e8ba6ce516b962182f5f3261b804e59d6c95
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Tue Feb 3 16:41:31 2026 +0100
target/sparc: Remove dubious swapping in LD_code() helper
Since the endianness is contained in %oi, cpu_ld*_code_mmu() has
already honored it. Swapping again makes no sense. Remove the
bswap() calls.
Fixes: 2786a3f8d3a ("Use GET_ASI_CODE for ASI_KERNELTXT / ASI_USERTXT")
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20260203230054.23667-4-philmd@linaro.org>
diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c
index 3bc6a6827a..4ec8799d1f 100644
--- a/target/sparc/ldst_helper.c
+++ b/target/sparc/ldst_helper.c
@@ -1169,27 +1169,18 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ulong addr, uint32_t oi)
break;
case MO_16:
ret = cpu_ldw_code_mmu(env, addr, oi, ra);
- if ((mop & MO_BSWAP) != MO_TE) {
- ret = bswap16(ret);
- }
if (mop & MO_SIGN) {
ret = (int16_t)ret;
}
break;
case MO_32:
ret = cpu_ldl_code_mmu(env, addr, oi, ra);
- if ((mop & MO_BSWAP) != MO_TE) {
- ret = bswap32(ret);
- }
if (mop & MO_SIGN) {
ret = (int32_t)ret;
}
break;
case MO_64:
ret = cpu_ldq_code_mmu(env, addr, oi, ra);
- if ((mop & MO_BSWAP) != MO_TE) {
- ret = bswap64(ret);
- }
break;
default:
g_assert_not_reached();