Commit f9559d818205 for kernel

commit f9559d818205a4a0b9cd87181ef46e101ea11157
Author: Brett Creeley <brett.creeley@amd.com>
Date:   Mon Apr 21 10:46:05 2025 -0700

    pds_core: Remove unnecessary check in pds_client_adminq_cmd()

    When the pds_core driver was first created there were some race
    conditions around using the adminq, especially for client drivers.
    To reduce the possibility of a race condition there's a check
    against pf->state in pds_client_adminq_cmd(). This is problematic
    for a couple of reasons:

    1. The PDSC_S_INITING_DRIVER bit is set during probe, but not
       cleared until after everything in probe is complete, which
       includes creating the auxiliary devices. For pds_fwctl this
       means it can't make any adminq commands until after pds_core's
       probe is complete even though the adminq is fully up by the
       time pds_fwctl's auxiliary device is created.

    2. The race conditions around using the adminq have been fixed
       and this path is already protected against client drivers
       calling pds_client_adminq_cmd() if the adminq isn't ready,
       i.e. see pdsc_adminq_post() -> pdsc_adminq_inc_if_up().

    Fix this by removing the pf->state check in pds_client_adminq_cmd()
    because invalid accesses to pds_core's adminq is already handled by
    pdsc_adminq_post()->pdsc_adminq_inc_if_up().

    Fixes: 10659034c622 ("pds_core: add the aux client API")
    Reviewed-by: Simon Horman <horms@kernel.org>
    Signed-off-by: Brett Creeley <brett.creeley@amd.com>
    Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
    Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
    Link: https://patch.msgid.link/20250421174606.3892-4-shannon.nelson@amd.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/amd/pds_core/auxbus.c b/drivers/net/ethernet/amd/pds_core/auxbus.c
index eeb72b1809ea..c9aac27883a3 100644
--- a/drivers/net/ethernet/amd/pds_core/auxbus.c
+++ b/drivers/net/ethernet/amd/pds_core/auxbus.c
@@ -107,9 +107,6 @@ int pds_client_adminq_cmd(struct pds_auxiliary_dev *padev,
 	dev_dbg(pf->dev, "%s: %s opcode %d\n",
 		__func__, dev_name(&padev->aux_dev.dev), req->opcode);

-	if (pf->state)
-		return -ENXIO;
-
 	/* Wrap the client's request */
 	cmd.client_request.opcode = PDS_AQ_CMD_CLIENT_CMD;
 	cmd.client_request.client_id = cpu_to_le16(padev->client_id);