Commit fe50309a for tesseract
commit fe50309a1766ec308f230efc60a30068e9b6e415
Author: Stefan Weil <sw@weilnetz.de>
Date: Sat Aug 22 07:58:08 2026 +0200
Fix inefficient empty string test in ScrollView menus (#4612)
Replace parent.equals("") with parent.isEmpty() in SVMenuBar and
SVPopupMenu, fixing CodeQL's inefficient-empty-string-test warning.
Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
diff --git a/java/com/google/scrollview/ui/SVMenuBar.java b/java/com/google/scrollview/ui/SVMenuBar.java
index 9a87524e..55104e9d 100644
--- a/java/com/google/scrollview/ui/SVMenuBar.java
+++ b/java/com/google/scrollview/ui/SVMenuBar.java
@@ -74,7 +74,7 @@ public class SVMenuBar implements ActionListener {
// A duplicate entry - we just throw it away, since its already in.
if (items.get(name) != null) { return; }
// A new submenu at the top-level
- if (parent.equals("")) {
+ if (parent.isEmpty()) {
JMenu jli = new JMenu(name);
SVAbstractMenuItem mli = new SVSubMenuItem(name, jli);
items.put(name, mli);
diff --git a/java/com/google/scrollview/ui/SVPopupMenu.java b/java/com/google/scrollview/ui/SVPopupMenu.java
index 6584447e..0a0a10ee 100644
--- a/java/com/google/scrollview/ui/SVPopupMenu.java
+++ b/java/com/google/scrollview/ui/SVPopupMenu.java
@@ -65,7 +65,7 @@ public class SVPopupMenu implements ActionListener {
// A duplicate entry - we just throw it away, since its already in.
if (items.get(name) != null) { return; }
// A new submenu at the top-level.
- if (parent.equals("")) {
+ if (parent.isEmpty()) {
JMenu jli = new JMenu(name);
SVAbstractMenuItem mli = new SVSubMenuItem(name, jli);
items.put(name, mli);