Commit 585e39e6487 for nodejs
commit 585e39e6487d778e562524a06f4b70b25318ca12
Author: Chengzhong Wu <legendecas@gmail.com>
Date: Wed Nov 18 09:41:14 2026 -0500
deps,v8: patch V8 to fix build with libstdc++ older than 12.3
libstdc++ before 12.3 passes the predicate of `std::erase_if` on a
`std::map` a const reference, so `KnaMap::EraseIf`, whose predicate
mutates the mapped value, fails to compile. Replace it with an explicit
erase loop.
Refs: https://gcc.gnu.org/PR107850
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/67070
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/common.gypi b/common.gypi
index d1577d1fc4b..ec134afceba 100644
--- a/common.gypi
+++ b/common.gypi
@@ -50,7 +50,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
- 'v8_embedder_string': '-node.3',
+ 'v8_embedder_string': '-node.4',
##### V8 defaults for Node.js #####
diff --git a/deps/v8/src/maglev/maglev-kna-map.h b/deps/v8/src/maglev/maglev-kna-map.h
index 3d3e6dce782..00a1956c40b 100644
--- a/deps/v8/src/maglev/maglev-kna-map.h
+++ b/deps/v8/src/maglev/maglev-kna-map.h
@@ -93,9 +93,18 @@ class KnaMap {
// place for surviving entries.
template <typename Pred>
size_t EraseIf(Pred&& pred) {
- return std::erase_if(map_, [&](value_type& entry) {
- return pred(entry.first, entry.second);
- });
+ // Not std::erase_if: libstdc++ before 12.3 passes the predicate a const
+ // reference (https://gcc.gnu.org/PR107850), but `pred` mutates Value&.
+ size_t erased = 0;
+ for (auto it = map_.begin(); it != map_.end();) {
+ if (pred(it->first, it->second)) {
+ it = map_.erase(it);
+ ++erased;
+ } else {
+ ++it;
+ }
+ }
+ return erased;
}
// Visits all entries in ascending key order, allowing `fn(const Key&,