Commit 2b365b28928 for nodejs
commit 2b365b28928d9ab36f1e9b41f81beaca83fa772a
Author: Livia Medeiros <livia@cirno.name>
Date: Sun Nov 22 04:07:09 2026 +0800
lib: legitimize `SuppressedError` as primordial
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67551
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
diff --git a/lib/eslint.config_partial.mjs b/lib/eslint.config_partial.mjs
index f1985d93ea9..d9183423ed1 100644
--- a/lib/eslint.config_partial.mjs
+++ b/lib/eslint.config_partial.mjs
@@ -23,7 +23,7 @@ const noRestrictedSyntax = [
message: "`btoa` supports only latin-1 charset, use Buffer.from(str).toString('base64') instead",
},
{
- selector: 'NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError|AbortError|NodeAggregateError|QuicError|QuotaExceededError)$/])',
+ selector: 'NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError|AbortError|NodeAggregateError|QuicError|QuotaExceededError|SuppressedError)$/])',
message: "Use an error exported by 'internal/errors' instead.",
},
{
@@ -507,6 +507,7 @@ export default [
into: 'Safe',
},
{ name: 'String' },
+ { name: 'SuppressedError' },
{ name: 'Symbol' },
{ name: 'SyntaxError' },
{ name: 'TypeError' },
diff --git a/lib/internal/quic/quic.js b/lib/internal/quic/quic.js
index 6a10f0f94ff..92942c26e17 100644
--- a/lib/internal/quic/quic.js
+++ b/lib/internal/quic/quic.js
@@ -19,6 +19,7 @@ const {
PromisePrototypeThen,
PromiseWithResolvers,
SafeSet,
+ SuppressedError,
Symbol,
SymbolAsyncDispose,
SymbolAsyncIterator,
@@ -1231,14 +1232,12 @@ function invokeOnerror(fn, error) {
if (isPromise(result)) {
PromisePrototypeThen(result, undefined, (err) => {
process.nextTick(() => {
- // eslint-disable-next-line no-restricted-syntax
throw new SuppressedError(err, error, err?.message);
});
});
}
} catch (err) {
process.nextTick(() => {
- // eslint-disable-next-line no-restricted-syntax
throw new SuppressedError(err, error, err?.message);
});
}
diff --git a/lib/internal/streams/iter/consumers.js b/lib/internal/streams/iter/consumers.js
index 0751d2cc95f..4549aeb924d 100644
--- a/lib/internal/streams/iter/consumers.js
+++ b/lib/internal/streams/iter/consumers.js
@@ -22,6 +22,7 @@ const {
PromisePrototypeThen,
SafePromiseAllReturnVoid,
SafeSet,
+ SuppressedError,
Symbol,
SymbolAsyncIterator,
TypedArrayPrototypeGetBuffer,
@@ -645,7 +646,6 @@ async function cleanupIterators(iterators, primaryError, pendingPulls) {
// Both a primary error and a cleanup error occurred.
// Wrap in SuppressedError so neither is lost:
// .error = primaryError, .suppressed = cleanupError.
- // eslint-disable-next-line no-restricted-syntax
throw new SuppressedError(primaryError, cleanupError);
}
// No primary error - the cleanup error is the only error.