Commit 3952ee06d9b for php
commit 3952ee06d9ba2206f78da6ffda89c6cb7e62e834
Author: Weilin Du <weilindu@php.net>
Date: Thu Oct 15 00:19:43 2026 +0800
ext/readline: Remove unreachable branches and useless includes (#24318)
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 77a52f25120..828ee6093a0 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -499,8 +499,6 @@ static void php_rl_callback_handler(char *the_line)
zval params[1];
zval dummy;
- ZVAL_NULL(&dummy);
-
_readline_string_zval(¶ms[0], the_line);
call_user_function(NULL, NULL, &_prepped_callback, &dummy, 1, params);
diff --git a/ext/readline/readline_cli.c b/ext/readline/readline_cli.c
index 89d378e2d7d..86db1cb91c4 100644
--- a/ext/readline/readline_cli.c
+++ b/ext/readline/readline_cli.c
@@ -26,7 +26,6 @@
#include "zend_hash.h"
#include "SAPI.h"
-#include <locale.h>
#include "zend.h"
#include "php_ini.h"
#include "ext/standard/info.h"
@@ -45,7 +44,6 @@
#include "zend_compile.h"
#include "zend_execute.h"
-#include "zend_highlight.h"
#include "zend_exceptions.h"
#include "sapi/cli/cli.h"
@@ -472,9 +470,7 @@ static char *cli_completion_generator_ht(const char *text, size_t textlen, int *
rl_completion_append_character = append_character;
return retval;
}
- if (zend_hash_move_forward(ht) == FAILURE) {
- break;
- }
+ zend_hash_move_forward(ht);
}
(*state)++;
return NULL;