Commit 551e180e2f for qemu.org
commit 551e180e2fd484a8335b91a4b866a1def513cd5a
Author: Peter Xu <peterx@redhat.com>
Date: Tue Sep 29 18:50:14 2026 -0500
machine: Rename machine_require_guest_memfd() to *_private()
Differentiate it from fully shared guest-memfd use cases.
When at it, add proper brackets in kvm_handle_hc_map_gpa_range()
otherwise checkpatch may complain.
Suggested-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Michael Roth <michael.roth@amd.com>
Reviewed-by: David Hildenbrand <david@kernel.org>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Link: https://lore.kernel.org/r/20260929235109.1398509-9-michael.roth@amd.com
Signed-off-by: Peter Xu <peterx@redhat.com>
diff --git a/backends/hostmem.c b/backends/hostmem.c
index a41540d50d..8782c8b1ea 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -290,7 +290,7 @@ static void host_memory_backend_init(Object *obj)
/* TODO: convert access to globals to compat properties */
backend->merge = machine_mem_merge(machine);
backend->dump = machine_dump_guest_core(machine);
- backend->guest_memfd_private = machine_require_guest_memfd(machine);
+ backend->guest_memfd_private = machine_require_guest_memfd_private(machine);
backend->reserve = true;
backend->prealloc_threads = machine->smp.cpus;
}
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 92f7be52a1..438624ece3 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1337,7 +1337,7 @@ bool machine_mem_merge(MachineState *machine)
return machine->mem_merge;
}
-bool machine_require_guest_memfd(MachineState *machine)
+bool machine_require_guest_memfd_private(MachineState *machine)
{
return machine->cgs && machine->cgs->require_guest_memfd;
}
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index b649f184de..2fd90fa739 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -873,7 +873,7 @@ void pc_memory_init(PCMachineState *pcms,
if (!is_tdx_vm()) {
option_rom_mr = g_malloc(sizeof(*option_rom_mr));
- if (machine_require_guest_memfd(machine)) {
+ if (machine_require_guest_memfd_private(machine)) {
memory_region_init_ram_guest_memfd(option_rom_mr, NULL, "pc.rom",
PC_ROM_SIZE, &error_fatal);
} else {
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index 441e777191..b6a56ef1fd 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -51,7 +51,7 @@ static void pc_isa_bios_init(PCMachineState *pcms, MemoryRegion *isa_bios,
/* map the last 128KB of the BIOS in ISA space */
isa_bios_size = MIN(flash_size, 128 * KiB);
- if (machine_require_guest_memfd(MACHINE(pcms))) {
+ if (machine_require_guest_memfd_private(MACHINE(pcms))) {
memory_region_init_ram_guest_memfd(isa_bios, NULL, "isa-bios",
isa_bios_size, &error_fatal);
} else {
@@ -70,7 +70,7 @@ static void pc_isa_bios_init(PCMachineState *pcms, MemoryRegion *isa_bios,
((uint8_t*)flash_ptr) + (flash_size - isa_bios_size),
isa_bios_size);
- if (!machine_require_guest_memfd(current_machine)) {
+ if (!machine_require_guest_memfd_private(current_machine)) {
memory_region_set_readonly(isa_bios, true);
}
}
diff --git a/hw/i386/x86-common.c b/hw/i386/x86-common.c
index ae58352760..59e92b1a1b 100644
--- a/hw/i386/x86-common.c
+++ b/hw/i386/x86-common.c
@@ -1036,7 +1036,7 @@ static void load_bios_from_file(X86MachineState *x86ms, const char *bios_name,
ssize_t ret;
/* BIOS load */
- if (machine_require_guest_memfd(MACHINE(x86ms))) {
+ if (machine_require_guest_memfd_private(MACHINE(x86ms))) {
memory_region_init_ram_guest_memfd(&x86ms->bios, NULL, "pc.bios",
bios_size, &error_fatal);
if (is_tdx_vm()) {
@@ -1106,7 +1106,7 @@ void x86_bios_rom_init(X86MachineState *x86ms, const char *default_firmware,
bios_size = get_bios_size(x86ms, bios_name, filename);
load_bios_from_file(x86ms, bios_name, filename, bios_size, isapc_ram_fw);
- if (!machine_require_guest_memfd(MACHINE(x86ms))) {
+ if (!machine_require_guest_memfd_private(MACHINE(x86ms))) {
/* map the last 128KB of the BIOS in ISA space */
x86_isa_bios_init(&x86ms->isa_bios, rom_memory, &x86ms->bios,
!isapc_ram_fw);
diff --git a/include/hw/core/boards.h b/include/hw/core/boards.h
index 3b86724cf0..d0e4ad9820 100644
--- a/include/hw/core/boards.h
+++ b/include/hw/core/boards.h
@@ -43,7 +43,7 @@ bool machine_usb(MachineState *machine);
int machine_phandle_start(MachineState *machine);
bool machine_dump_guest_core(MachineState *machine);
bool machine_mem_merge(MachineState *machine);
-bool machine_require_guest_memfd(MachineState *machine);
+bool machine_require_guest_memfd_private(MachineState *machine);
HotpluggableCPUList *machine_query_hotpluggable_cpus(MachineState *machine);
void machine_set_cpu_numa_node(MachineState *machine,
const CpuInstanceProperties *props,
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 1eeadb99ad..a72b6e6b74 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -6488,8 +6488,9 @@ static int kvm_handle_hc_map_gpa_range(X86CPU *cpu, struct kvm_run *run)
uint64_t gpa, size, attributes;
int ret;
- if (!machine_require_guest_memfd(current_machine))
+ if (!machine_require_guest_memfd_private(current_machine)) {
return -EINVAL;
+ }
gpa = run->hypercall.args[0];
size = run->hypercall.args[1] * TARGET_PAGE_SIZE;