Commit 62e8d66257 for aom
commit 62e8d662571ce16ee2d5a4e7900b8291a4fac2a6
Author: Jerome Jiang <jianj@google.com>
Date: Tue Nov 17 12:56:34 2026 -0500
Zero-initialize cdf_a in AV1.TestWriteSymbolState
RandomCdf() in AV1.TestWriteSymbolState (added in 331c56b1ca) only
initializes the first k + 3 entries of each row in cdf_a, leaving
trailing slots up to CDF_SIZE(kMaxSymbs) uninitialized before memcpy
and full-buffer memcmp. This triggers Valgrind uninitialized-value
errors in bcmp.
Zero-initialize cdf_a so all elements are defined.
TAG=agy
CONV=5b115185-1948-4643-9443-0c13fda91c99
Change-Id: I4aa74f9ed89d48bce237321dab4c9bddd3abb22e
diff --git a/test/boolcoder_test.cc b/test/boolcoder_test.cc
index 6e5c8db6b5..4fe274e539 100644
--- a/test/boolcoder_test.cc
+++ b/test/boolcoder_test.cc
@@ -198,7 +198,7 @@ TEST(AV1, TestWriteSymbolState) {
const int kNumCdfs = kMaxSymbs - 1;
const int kBufferSize = 3 * kSymbols;
for (int n = 0; n < num_tests; ++n) {
- aom_cdf_prob cdf_a[kNumCdfs][CDF_SIZE(kMaxSymbs)];
+ aom_cdf_prob cdf_a[kNumCdfs][CDF_SIZE(kMaxSymbs)] = {};
aom_cdf_prob cdf_b[kNumCdfs][CDF_SIZE(kMaxSymbs)];
aom_cdf_prob cdf_r[kNumCdfs][CDF_SIZE(kMaxSymbs)];
for (int k = 0; k < kNumCdfs; ++k) RandomCdf(&rnd, k + 2, cdf_a[k]);