Commit 77b233ded2 for bind
commit 77b233ded29353c1a4f06a5ae63755d468cc0001
Author: Martin Basti <mbasti@isc.org>
Date: Tue Oct 27 12:45:04 2026 +0000
Remove duplicated dns_db_commitupdate() call in ixfr_apply_one()
Commit da53708d "Implement qpzone specific update path" added
a second dns_db_commitupdate() call right above the existing one.
It is harmless because commitupdate is required to be safe to double-call,
but it is dead code with a comment that duplicates the one below it.
Keep a single call and merge the two comments.
Assisted-by: Claude:claude-fable-5-1
diff --git a/lib/dns/xfrin.c b/lib/dns/xfrin.c
index 06755fffb0..914ada8349 100644
--- a/lib/dns/xfrin.c
+++ b/lib/dns/xfrin.c
@@ -510,16 +510,10 @@ ixfr_apply_one(dns_xfrin_t *xfr, ixfr_apply_data_t *data) {
if (xfr->ixfr.journal != NULL) {
CHECK(dns_journal_writediff(xfr->ixfr.journal, &data->diff));
}
- /*
- * In the current implementation, we always commit the results, since
- * dns_zone_verifydb doesn't know how to access the in-progress
- * transaction.
- */
- dns_db_commitupdate(xfr->db, &callbacks);
-
/*
* At the moment, rdatacallbacks doesn't offer a way to inspect the
- * result of a transaction before committing it.
+ * result of a transaction before committing it, so dns_zone_verifydb
+ * can't see the in-progress transaction.
*
* So we need to commit *before* calling dns_zone_verifydb, and rely
* on closeversion to actually do cleanup.