Commit 947c71d195 for frr
commit 947c71d1958a7c01f9756a61567593f58c6983e5
Author: Donald Sharp <sharpd@nvidia.com>
Date: Thu Nov 12 10:47:01 2026 -0500
bgpd: add accessors for the MAC mobility sync sequence
Add bgp_attr_get_mm_sync_seqnum() and bgp_attr_set_mm_sync_seqnum()
and use them for every read and write of the highest MAC mobility
sequence learned from an Ethernet Segment peer.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index c768ab66f4..c04ccd2e26 100644
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -1462,7 +1462,7 @@ bool attrhash_cmp(const void *p1, const void *p2)
!memcmp(&attr1->esi, &attr2->esi, sizeof(esi_t)) &&
bgp_attr_get_es_flags(attr1) == bgp_attr_get_es_flags(attr2) &&
bgp_attr_get_mm_seqnum(attr1) == bgp_attr_get_mm_seqnum(attr2) &&
- attr1->mm_sync_seqnum == attr2->mm_sync_seqnum &&
+ bgp_attr_get_mm_sync_seqnum(attr1) == bgp_attr_get_mm_sync_seqnum(attr2) &&
bgp_attr_get_df_pref(attr1) == bgp_attr_get_df_pref(attr2) &&
bgp_attr_get_df_alg(attr1) == bgp_attr_get_df_alg(attr2) &&
attr1->nh_ifindex == attr2->nh_ifindex &&
diff --git a/bgpd/bgp_attr.h b/bgpd/bgp_attr.h
index dba9cafe44..c3c492a77d 100644
--- a/bgpd/bgp_attr.h
+++ b/bgpd/bgp_attr.h
@@ -885,6 +885,16 @@ static inline void bgp_attr_set_mm_seqnum(struct attr *attr, uint32_t mm_seqnum)
attr->mm_seqnum = mm_seqnum;
}
+static inline uint32_t bgp_attr_get_mm_sync_seqnum(const struct attr *attr)
+{
+ return attr->mm_sync_seqnum;
+}
+
+static inline void bgp_attr_set_mm_sync_seqnum(struct attr *attr, uint32_t mm_sync_seqnum)
+{
+ attr->mm_sync_seqnum = mm_sync_seqnum;
+}
+
static inline struct bgp_route_evpn *
bgp_attr_get_evpn_overlay(const struct attr *attr)
{
diff --git a/bgpd/bgp_evpn.c b/bgpd/bgp_evpn.c
index b94c2b3f73..39ea0a0ffe 100644
--- a/bgpd/bgp_evpn.c
+++ b/bgpd/bgp_evpn.c
@@ -2247,7 +2247,7 @@ static void update_evpn_route_entry_sync_info(struct bgp *bgp,
&max_sync_seq, &active_on_peer,
&peer_router, &proxy_from_peer,
mac);
- attr->mm_sync_seqnum = max_sync_seq;
+ bgp_attr_set_mm_sync_seqnum(attr, max_sync_seq);
es_flags = bgp_attr_get_es_flags(attr);
if (active_on_peer)
SET_FLAG(es_flags, ATTR_ES_PEER_ACTIVE);
@@ -2285,7 +2285,7 @@ static void update_evpn_route_entry_sync_info(struct bgp *bgp,
} else {
es_flags = bgp_attr_get_es_flags(attr);
- attr->mm_sync_seqnum = 0;
+ bgp_attr_set_mm_sync_seqnum(attr, 0);
UNSET_FLAG(es_flags, ATTR_ES_PEER_ACTIVE);
UNSET_FLAG(es_flags, ATTR_ES_PEER_PROXY);
bgp_attr_set_es_flags(attr, es_flags);
diff --git a/bgpd/bgp_evpn_mh.h b/bgpd/bgp_evpn_mh.h
index 4b363a1c0a..0cef7650a3 100644
--- a/bgpd/bgp_evpn_mh.h
+++ b/bgpd/bgp_evpn_mh.h
@@ -366,7 +366,7 @@ static inline bool bgp_evpn_attr_is_sync(struct attr *attr)
static inline uint32_t bgp_evpn_attr_get_sync_seq(struct attr *attr)
{
- return attr ? attr->mm_sync_seqnum : 0;
+ return attr ? bgp_attr_get_mm_sync_seqnum(attr) : 0;
}
static inline bool bgp_evpn_attr_is_active_on_peer(struct attr *attr)
diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 9ca0494570..96584d5687 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -13761,24 +13761,19 @@ static void route_vty_out_detail_es_info(struct vty *vty,
if (peer_router)
json_object_boolean_true_add(
json_es_info, "peerRouter");
- if (attr->mm_sync_seqnum)
- json_object_int_add(
- json_es_info, "peerSeq",
- attr->mm_sync_seqnum);
+ if (bgp_attr_get_mm_sync_seqnum(attr))
+ json_object_int_add(json_es_info, "peerSeq",
+ bgp_attr_get_mm_sync_seqnum(attr));
json_object_object_add(
json_path, "es_info",
json_es_info);
}
} else {
if (bgp_evpn_attr_is_sync(attr))
- vty_out(vty,
- " ESI %s %s peer-info: (%s%s%sMM: %d)\n",
- esi_buf,
- es_local ? "local-es":"",
- peer_proxy ? "proxy " : "",
- peer_active ? "active ":"",
- peer_router ? "router ":"",
- attr->mm_sync_seqnum);
+ vty_out(vty, " ESI %s %s peer-info: (%s%s%sMM: %d)\n", esi_buf,
+ es_local ? "local-es" : "", peer_proxy ? "proxy " : "",
+ peer_active ? "active " : "", peer_router ? "router " : "",
+ bgp_attr_get_mm_sync_seqnum(attr));
else
vty_out(vty, " ESI %s %s\n",
esi_buf,