Commit a2ec5a32e43 for php
commit a2ec5a32e43a5b434d108b0c18910a368c21a42b
Author: Weilin Du <weilindu@php.net>
Date: Sat Oct 10 03:21:41 2026 +0800
ext/readline: Compute completion prefix length outside the loop
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index d9ec274996c..91cd751559e 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -417,6 +417,7 @@ static char *_readline_command_generator(const char *text, int state)
{
HashTable *myht = Z_ARRVAL(_readline_array);
zval *entry;
+ size_t text_len = strlen(text);
if (!state) {
zend_hash_internal_pointer_reset(myht);
@@ -426,7 +427,7 @@ static char *_readline_command_generator(const char *text, int state)
zend_hash_move_forward(myht);
convert_to_string(entry);
- if (strncmp (Z_STRVAL_P(entry), text, strlen(text)) == 0) {
+ if (strncmp (Z_STRVAL_P(entry), text, text_len) == 0) {
return (strdup(Z_STRVAL_P(entry)));
}
}