Commit beb24ceb27 for ffmpeg
commit beb24ceb273ea726c78face788b3d45eaa4796d3
Author: Kacper Michajłow <kasper93@gmail.com>
Date: Wed Oct 28 20:44:28 2026 +0100
fate/ogg-vorbis: pipe the chained-large-comment inputs
The test read its two parts through a concat: URL built from
target_path, which is not portable and doesn't work with Windows pathes,
at least not with enough escaping sprinkled on top. Pipe both parts
straight into the framecrc run and pass the comment to -/metadata
through a pipe, so the test writes no files.
Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
diff --git a/tests/fate/ogg-vorbis.mak b/tests/fate/ogg-vorbis.mak
index 51d6a9e4d6..d009f4e818 100644
--- a/tests/fate/ogg-vorbis.mak
+++ b/tests/fate/ogg-vorbis.mak
@@ -9,16 +9,12 @@ fate-ogg-vorbis-copy-chained-meta: CMD = run_with_temp "$(FFMPEG) -nostdin -hide
# Chain two streams cut from the same sample, the second one with a comment
# header larger than 64 KiB (as with embedded cover art).
-FATE_OGG_COPY_VORBIS-$(call FRAMECRC, OGG FFMETADATA, VORBIS, OGG_MUXER CONCAT_PROTOCOL) += fate-ogg-vorbis-chained-large-comment
+FATE_OGG_COPY_VORBIS-$(call FRAMECRC, OGG, VORBIS, OGG_MUXER) += fate-ogg-vorbis-chained-large-comment
fate-ogg-vorbis-chained-large-comment: CMD = \
- cleanfiles="$${cleanfiles} $${outfile}.txt $${outfile}.1.ogg $${outfile}.2.ogg"; \
- printf ";FFMETADATA1\ncomment=%070000d\n" 0 > "$${outfile}.txt" && \
- ffmpeg -i $(TARGET_SAMPLES)/vorbis/moog_small.ogg -c copy -t 0.5 -fflags +bitexact \
- -y "$$(target_path "$${outfile}.1.ogg")" && \
- ffmpeg -i $(TARGET_SAMPLES)/vorbis/moog_small.ogg -i "$$(target_path "$${outfile}.txt")" \
- -map 0 -map_metadata 1 -c copy -t 0.5 -fflags +bitexact -serial_offset 1 \
- -y "$$(target_path "$${outfile}.2.ogg")" && \
- framecrc -i "concat:$$(target_path "$${outfile}.1.ogg")|$$(target_path "$${outfile}.2.ogg")" -c copy
+ { ffmpeg -i $(TARGET_SAMPLES)/vorbis/moog_small.ogg -c copy -t 0.5 -fflags +bitexact -f ogg - && \
+ printf "comment=%070000d" 0 | ffmpeg -i $(TARGET_SAMPLES)/vorbis/moog_small.ogg -/metadata pipe: \
+ -c copy -t 0.5 -fflags +bitexact -serial_offset 1 -f ogg -; } | \
+ framecrc -i - -c copy
FATE_OGG_VORBIS_PROBE-$(call DEMDEC, OGG, VORBIS) += fate-ogg-vorbis-initial-padding-chained
fate-ogg-vorbis-initial-padding-chained: CMD = ffprobe_demux -of default -show_entries stream=codec_name,initial_padding $(TARGET_SAMPLES)/ogg-vorbis/chained-meta.ogg