Commit c570b675932 for nodejs
commit c570b6759328bdd6f8463626021a3ef728d44996
Author: Filip Skokan <panva.ip@gmail.com>
Date: Sat Sep 26 15:38:13 2026 +0200
test: unmark loader inspector wait test as flaky
Disconnecting the inspector can race with its final notification write.
If EOF resets the socket first, the write used to dereference a null
TCP handle. 8a84e6be900 added guards for writes after disconnect.
Removing those guards reproduces the loader test's SIGSEGV under a
scheduling-delay probe; the normal binary passes the same probe.
Remove the flaky expectations left over from before that fix.
Refs: https://github.com/nodejs/node/issues/54346
Refs: https://github.com/nodejs/node/issues/34833
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Claude, Codex
PR-URL: https://github.com/nodejs/node/pull/66319
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
index d9195059ac3..de658a702b4 100644
--- a/test/parallel/parallel.status
+++ b/test/parallel/parallel.status
@@ -27,8 +27,6 @@ test-fs-cp-async-symlink-points-to-dest: SKIP
[$system==win32 && $arch==arm64]
[$system==linux]
-# https://github.com/nodejs/node/issues/54346
-test-esm-loader-hooks-inspect-wait: PASS, FLAKY
[$system==macos]
# https://github.com/nodejs/node/issues/42741
@@ -58,8 +56,6 @@ test-domain-no-error-handler-abort-on-uncaught-8: PASS, FLAKY
test-domain-no-error-handler-abort-on-uncaught-9: PASS, FLAKY
test-domain-throw-error-then-throw-from-uncaught-exception-handler: PASS, FLAKY
test-domain-with-abort-on-uncaught-exception: PASS, FLAKY
-# https://github.com/nodejs/node/issues/54346
-test-esm-loader-hooks-inspect-wait: PASS, FLAKY
# https://github.com/nodejs/node/issues/61520
test-fs-promises-watch-iterator: SKIP
test-fs-promises-watch-ignore-function: SKIP
@@ -74,8 +70,6 @@ test-fs-watch-ignore-regexp: SKIP
test-tick-processor-arguments: SKIP
[$system==freebsd]
-# https://github.com/nodejs/node/issues/54346
-test-esm-loader-hooks-inspect-wait: PASS, FLAKY
# https://github.com/nodejs/node/issues/61520
test-fs-promises-watch-iterator: SKIP
test-fs-promises-watch-ignore-function: SKIP
@@ -88,8 +82,6 @@ test-fs-watch-ignore-mixed: SKIP
test-fs-watch-ignore-regexp: SKIP
[$system==aix]
-# https://github.com/nodejs/node/issues/54346
-test-esm-loader-hooks-inspect-wait: PASS, FLAKY
[$system==ibmi]
# https://github.com/nodejs/node/pull/30819