Commit d5a6b20f0c for frr
commit d5a6b20f0c3bc74d95945236f756b64c90221058
Author: Philippe Guibert <philippe.guibert@6wind.com>
Date: Wed Oct 7 17:25:59 2026 +0200
bgpd: fix help string of expanded community-list commands
The help of the last argument of the expanded community-list commands
describes a community value, whereas an expanded community-list takes a
regular expression:
> rt1(config)# bgp community-list expanded TEST permit ?
> AA:NN Community number in AA:NN format (where AA and NN are
> (0-65535)) or local-AS|no-advertise|no-export|internet|...
The 'bgp community-list <(100-500)|expanded NAME> ... <deny|permit>'
command and its 'no' form use an AA:NN... token documented with
COMMUNITY_VAL_STR, while the extended and large expanded community-list
commands use a LINE... token documented as "An ordered list as a
regular-expression".
Use the same token and help string for the expanded community-list
commands. The accepted syntax is unchanged.
Fixes: 5bf159563c12 ("bgpd: bgp_vty.c compiles now")
Fixes: 42f914d4dd6e ("bgpd: Refactor community-list commands")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
index 8480443c36..20289430ea 100644
--- a/bgpd/bgp_vty.c
+++ b/bgpd/bgp_vty.c
@@ -25488,7 +25488,7 @@ ALIAS(no_community_list_standard_all, no_bgp_community_list_standard_all_list_cm
/*community-list expanded */
DEFUN (community_list_expanded_all,
bgp_community_list_expanded_all_cmd,
- "bgp community-list <(100-500)|expanded COMMUNITY_LIST_NAME> [seq (0-4294967295)] <deny|permit> AA:NN...",
+ "bgp community-list <(100-500)|expanded COMMUNITY_LIST_NAME> [seq (0-4294967295)] <deny|permit> LINE...",
BGP_STR
COMMUNITY_LIST_STR
"Community list number (expanded)\n"
@@ -25498,7 +25498,7 @@ DEFUN (community_list_expanded_all,
"Sequence number\n"
"Specify community to reject\n"
"Specify community to accept\n"
- COMMUNITY_VAL_STR)
+ "An ordered list as a regular-expression\n")
{
char *cl_name_or_number = NULL;
char *seq = NULL;
@@ -25516,7 +25516,7 @@ DEFUN (community_list_expanded_all,
cl_name_or_number = argv[idx]->arg;
direct = argv_find(argv, argc, "permit", &idx) ? COMMUNITY_PERMIT
: COMMUNITY_DENY;
- argv_find(argv, argc, "AA:NN", &idx);
+ argv_find(argv, argc, "LINE", &idx);
char *str = argv_concat(argv, argc, idx);
assert(str);
@@ -25536,7 +25536,7 @@ DEFUN (community_list_expanded_all,
DEFUN (no_community_list_expanded_all,
no_bgp_community_list_expanded_all_cmd,
- "no bgp community-list <(100-500)|expanded COMMUNITY_LIST_NAME> [seq (0-4294967295)] <deny|permit> AA:NN...",
+ "no bgp community-list <(100-500)|expanded COMMUNITY_LIST_NAME> [seq (0-4294967295)] <deny|permit> LINE...",
NO_STR
BGP_STR
COMMUNITY_LIST_STR
@@ -25547,7 +25547,7 @@ DEFUN (no_community_list_expanded_all,
"Sequence number\n"
"Specify community to reject\n"
"Specify community to accept\n"
- COMMUNITY_VAL_STR)
+ "An ordered list as a regular-expression\n")
{
char *cl_name_or_number = NULL;
char *seq = NULL;
@@ -25569,7 +25569,7 @@ DEFUN (no_community_list_expanded_all,
: COMMUNITY_DENY;
idx = 0;
- argv_find(argv, argc, "AA:NN", &idx);
+ argv_find(argv, argc, "LINE", &idx);
str = argv_concat(argv, argc, idx);
}