Commit e06ced8227 for openssl.org
commit e06ced8227f4117aac830f99d0c7e26521847f8c
Author: Richard Levitte <levitte@openssl.foundation>
Date: Tue Nov 17 11:56:25 2026 +0100
.github/workflows/ci.yml: build NSS without -Werror
NSS's coreconf/Werror.mk adds -Werror to the build, which newer gcc
trips on NSS's own code (seen with gcc 15 on the ubuntu-26.04
runners: -Werror=discarded-qualifiers in genload.c, fixed on NSS
master but in no release yet). Linting NSS is not this job's
purpose, so override WARNING_CFLAGS on the make command line.
Assisted-by: Pi:moonshotai/kimi-k3
Signed-off-by: Richard Levitte <levitte@openssl.foundation>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Merge-date: Wed Nov 18 06:24:08 2026
Merged-from: https://github.com/openssl/openssl/pull/33789
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8d06080fc5..de03fdea27 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -818,7 +818,9 @@ jobs:
"$GITHUB_WORKSPACE"/.github/retry sh -c 'rm -rf nss && git clone --depth 1 --branch NSS_3_112_3_RTM https://github.com/nss-dev/nss.git'
"$GITHUB_WORKSPACE"/.github/retry sh -c 'rm -rf nspr && hg clone https://hg.mozilla.org/projects/nspr -r NSPR_4_36_BRANCH'
cd nss
- USE_64=1 make nss_build_all
+ # NSS's own Werror.mk adds -Werror; newer gcc (ubuntu-26.04) trips it
+ # on NSS's own code, which is not this job's business to lint.
+ USE_64=1 make nss_build_all WARNING_CFLAGS="-Wall -Wshadow"
USE_64=1 make install
cd ../..
- name: Test ECH with NSS